Dictionary

[LeMikaelF]

Changelist

• Implemented dictionary functionality (English only)

Type of change

• [ ] Bug fix (non-breaking change which fixes an issue)
• [X] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] Documentation (adds or revises project documentation)

Local configuration:

• OS: Linux (Ubuntu 16.04)
• JDK: OpenJDK 11.0.4+11

[LeMikaelF]

Hmm… no idea why the build fails. It works fine on my machine. I'll look into it.

[LeMikaelF]

Turns out, it was a bug in OpenJDK 11. The workaround is simply not to use the diamond operator in a parameterized type, but to specify the type parameter explicitly.

It's annoying, because the fix was backported to OpenJDK 11.0.4, but Travis CI uses 11.0.2. And it doesn't look like you can make Travis use a specific minor version of a JDK.

[zzzowoey]

The extra dependencies seem to break the build tools on Windows because the call to jdeps is too long (almost 34,000 characters). I'll have to figure out a workaround for this.

Other than that, though, this looks great and works great. I'll merge after I figure out the issue.

[zzzowoey]

I was hoping to future-proof the build tools by fixing this at the command-line level, but it appears there's not really a way to do that with the current state of jdeps and the limits of Windows' CLI. The build tools still work on Linux, so Travis won't have any problems, but evidently we'll need to be careful with adding dependencies if we want to keep them working on Windows.

Anyhow, replacing spring-boot-starter-data-rest with spring-data-rest-webmvc alone keeps it working for now. This'll be merged sometime tonight.

[zzzowoey]

Merged - #23