ghost-discord / ghost

🤖 A modular, multi-feature Discord bot

GNU General Public License v3.0

23 stars 31 forks source link

Implemented a Fortune command, with optional arguments for a category. #52

Closed weakphish closed 4 years ago

weakphish commented 4 years ago

Changelist

I implemented a Fortune command g!fortune <category> that pulls a random fortune from an API and sends it in channel.

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[X] New feature (non-breaking change which adds functionality)
[ ] Documentation (adds or revises project documentation)

Local configuration:

OS: (Windows)
JDK: (Oracle 8)

weakphish commented 4 years ago

Thanks for the review! I'll implement your changes when I have time this week.

weakphish commented 4 years ago

@cbryant02 I think I fixed what you were looking for, but for whatever reason builds fail and I cannot compile without the try/catch in the CommandDispatcher.java. If you could guide me on how to get rid of that, I would appreciate it!

zocat64 commented 4 years ago

Module still has a throws clause for IOException. Looks like that's the only problem left, though.

weakphish commented 4 years ago

Removed it, but that seems to cause Travis CI to fail.

zocat64 commented 4 years ago

com/github/coleb1911/ghost2/commands/CommandDispatcher.java:80: error: exception IOException is never thrown in body of corresponding try statement

            } catch (IOException e) {

              ^

Gotta drop the try-catch now that the throws clause is gone.

weakphish commented 4 years ago

Whoops, going to pretend I'm not an idiot for missing that... ty! Fixed.

zocat64 commented 4 years ago

Awesome. Merged in 7ab27d4.