adds ngrok support for execution commands + tests - Githubissues

ghost-inspector / node-ghost-inspector

Ghost Inspector CLl & API Library for Node.js

https://ghostinspector.com/docs/api/

MIT License

28 stars 6 forks source link

adds ngrok support for execution commands + tests #34

Closed aaronfay closed 3 years ago

aaronfay commented 3 years ago

Adds ngrok support for execution endpoints:

❯ ghost-inspector test execute xxx \
  --ngrokTunnel localhost:8000 \
  --ngrokUrlVariable 'startUrl'

By default a variable ngrokUrl is provided via variables which has the tunnel endpoint. This can be customized by providing --ngrokUrlVariable foobar.

aaronfay commented 3 years ago

@justinklemm the build is failing for node-v8, I didn't even think to check but ngrok requires Node 10+. Being that Node 8 was deprecated last year is it something we can officially drop support for?

justinklemm commented 3 years ago

@aaronfay Yea, we can drop support for it. We'll just need to release this a v6. Can we add a CHANGELOG.md file as part of this PR that covers releases starting at v5 so that we can explicitly note that v6 drops Node.js v8 support?