ghost-inspector / node-ghost-inspector

Ghost Inspector CLl & API Library for Node.js
https://ghostinspector.com/docs/api/
MIT License
28 stars 6 forks source link

On demand test #9

Closed aaronfay closed 4 years ago

aaronfay commented 5 years ago

Adds on-demand test execution, and some cleanup. It took me a bit to figure out where the API key to run the integration tests comes from, I've updated the docs to be more specific about how to test things.

Specific changes:

@justinklemm it's not clear to me if you provide a CSV for executeTest() and specify immediate=true, is there a way to poll for these results as a whole? Or would we need to check each result individually?

PS: I've added the API key to run the integration tests into our vault. PPS: not sure what's up with CircleCI, digging into that next.

aaronfay commented 4 years ago

@justinklemm I'm blocked on a couple things here:

aaronfay commented 4 years ago

@simpixelated (and @justinklemm ) thanks for the feedback, I realized I was missing a couple tests for waitForTestResult and waitForSuiteResult and with your feedback I think the implementation is much cleaner. Latest changes in https://github.com/ghost-inspector/node-ghost-inspector/pull/9/commits/1ae23ce15425b714c853da21fa03f49b14dcade3

aaronfay commented 4 years ago

@justinklemm the version is bumped to 4.1.0, please release at your convenience 🙏