search

ghost1372 / HandyControls

Contains some simple and commonly used WPF controls based on HandyControl
https://ghost1372.github.io/
MIT License
1.07k stars 102 forks source link

DangerBrush for TextBox not applied #192

Closed dthoeni closed 1 year ago

dthoeni commented 1 year ago

Describe the bug

In the latest release a TextBox inside A GridView wont get rendered with a red border on error. I suspect this bug was introduced with the following commit:

Commit: 8e707a66a92868ba63d6083e8953164f0f18f0e5 [8e707a6] Parents: 322e3669c2 Author: NaBian 836904362@qq.com Date: Montag, 23. Jänner 2023 22:27:50 Committer: NaBian Commit Date: Sonntag, 29. Jänner 2023 23:49:17 enhance: optimize input elements.

Steps to reproduce the bug

Put a handyControl:TextBox inside a DataGrid and provoke a ValidationError

`

` ### Expected behavior Like in release 3.4.4 DangerBrush should be applied to the control. ### Screenshots Version 3.4.4 ![image](https://user-images.githubusercontent.com/30926969/230617227-e34bee84-db35-45fd-9b3a-b6a8c7c15347.png) Version 3.4.5 ![image](https://user-images.githubusercontent.com/30926969/230617375-49a2a382-407b-4178-b215-081ce28c3bd7.png) ### NuGet package version HandyControls (Custom version) 3.4.5 ### IDE Visual Studio 2022 ### Framework type .Net 7.0 ### Windows version Windows 11 (22621) ### Additional context _No response_
dthoeni commented 1 year ago

I figured out, that this problem is caused by changes to The TextBoxPlus_(Top/Left)_Template. The border element was moved into a Grid and is not visible anymore.

dthoeni commented 1 year ago

Reported on main project