ghost1372 / HandyControls

Contains some simple and commonly used WPF controls based on HandyControl
https://ghost1372.github.io/
MIT License
1.07k stars 102 forks source link

`DataGrid.InputBindings` with `MouseBinding` throw exception #213

Closed GF-Huang closed 6 months ago

GF-Huang commented 9 months ago

Describe the bug

At 3.4.5 it works no exception, 3.5.0 throw exception: ArgumentException: "MouseAction" property was registered by "MouseBinding".

Steps to reproduce the bug

Just use this code to reproduce:

<DataGrid>
  <DataGrid.InputBindings>
    <MouseBinding MouseAction="LeftDoubleClick" 
                  Command="{x:Static SystemCommands.CloseWindowCommand}" />
  </DataGrid.InputBindings>
</DataGrid>

Expected behavior

No response

Screenshots

No response

NuGet package version

HandyControls (Custom version) 3.5.0

IDE

Visual Studio 2022

Framework type

.Net 8.0

Windows version

Windows 11 (22621)

Additional context

No response

DineshSolanki commented 9 months ago

came here for this, same is happening in only v3.5.0

ghost1372 commented 9 months ago

Guys, I don't have enough time to work with WPF, I didn't add anything new, just synced with the main repo. So can you check commits and send a pr?

DineshSolanki commented 9 months ago

tried the code after reverting 8e1e8263f7918a142dc61f731fb9399f6927ed3e, seems to resolve this issue

ghost1372 commented 6 months ago

it seems that fixed https://github.com/HandyOrg/HandyControl/issues/1526