ghost1372 / HandyControls

Contains some simple and commonly used WPF controls based on HandyControl
https://ghost1372.github.io/
MIT License
1.1k stars 103 forks source link

Please read before creating Issue #48

Open ghost1372 opened 3 years ago

ghost1372 commented 3 years ago

Since this project is based on the official version and receives all its changes, in order to prevent code interference and rework, Please only mention issues related to the unofficial version here and Requests such as new language packs, bugs and new features should be listed on the official page.

SamirKharchi commented 3 years ago

So if I wanted to contribute a new feature to a control, I should rather fork from the official version and make a PR there? But what if I wanted to have the additional stuff from this repository AND my new feature? Will I have to wait until this repository receives my new feature (assuming it was merged) or will any PRs be automatically synced into this repository upon a merge event?

ghost1372 commented 3 years ago

Yes you have to fork the official version, At this time, I do not accept PR from this repository But if your PR is merged in the official version, it will be merged immediately in this repository

SamirKharchi commented 3 years ago

Ok thanks for the info!

o-medizadeh-Ard commented 5 months ago

the Growl with prameter 'ShowPersianDateTime = true,' has the following error on date '05/18/2024' : System.ArgumentOutOfRangeException: 'Year, Month, and Day parameters describe an un-representable DateTime.' But it works correctly on other dates.

ghost1372 commented 5 months ago

the Growl with prameter 'ShowPersianDateTime = true,' has the following error on date '05/18/2024' : System.ArgumentOutOfRangeException: 'Year, Month, and Day parameters describe an un-representable DateTime.' But it works correctly on other dates.

tnx, fixed in https://github.com/ghost1372/HandyControls/commit/905d65b5f6362d47c4ee5d645b01da3f135027a9

o-medizadeh-Ard commented 5 months ago

the Growl with prameter 'ShowPersianDateTime = true,' has the following error on date '05/18/2024' : System.ArgumentOutOfRangeException: 'Year, Month, and Day parameters describe an un-representable DateTime.' But it works correctly on other dates.

tnx, fixed in 905d65b

ok, Thanks. But the package that is downloaded from 'Nuget' has not been fixed yet and this bug still remains on the latest version 3.5.2. Thank

ghost1372 commented 5 months ago

ok, Thanks. But the package that is downloaded from 'Nuget' has not been fixed yet and this bug still remains on the latest version 3.5.2. Thank

fixed package will be available later. i am busy right now

o-medizadeh-Ard commented 5 months ago

ok, Thanks. But the package that is downloaded from 'Nuget' has not been fixed yet and this bug still remains on the latest version 3.5.2. Thank

fixed package will be available later. i am busy right now

Thanks. I have downloaded and installed the latest '3.5.2' package from nugget. Please guide me how to use your bug fix commit?

ghost1372 commented 5 months ago

ok, Thanks. But the package that is downloaded from 'Nuget' has not been fixed yet and this bug still remains on the latest version 3.5.2. Thank

fixed package will be available later. i am busy right now

Thanks. I have downloaded and installed the latest '3.5.2' package from nugget. Please guide me how to use your bug fix commit?

I haven't created a new package with the latest fix. The only way is to compile the project by yourself.

o-medizadeh-Ard commented 5 months ago

ok, Thanks. But the package that is downloaded from 'Nuget' has not been fixed yet and this bug still remains on the latest version 3.5.2. Thank

fixed package will be available later. i am busy right now

Thanks. I have downloaded and installed the latest '3.5.2' package from nugget. Please guide me how to use your bug fix commit?

I haven't created a new package with the latest fix. The only way is to compile the project by yourself.

Our team has developed a project based on this package for 6 months, and now such a problem has occurred during delivery. Thank you for your efforts in developing this application package Please update the package. thanks.

ghost1372 commented 5 months ago

ok, Thanks. But the package that is downloaded from 'Nuget' has not been fixed yet and this bug still remains on the latest version 3.5.2. Thank

fixed package will be available later. i am busy right now

Thanks. I have downloaded and installed the latest '3.5.2' package from nugget. Please guide me how to use your bug fix commit?

I haven't created a new package with the latest fix. The only way is to compile the project by yourself.

Our team has developed a project based on this package for 6 months, and now such a problem has occurred during delivery. Thank you for your efforts in developing this application package Please update the package. thanks.

v3.5.3 uploaded to nuget

o-medizadeh-Ard commented 5 months ago

ok, Thanks. But the package that is downloaded from 'Nuget' has not been fixed yet and this bug still remains on the latest version 3.5.2. Thank

fixed package will be available later. i am busy right now

Thanks. I have downloaded and installed the latest '3.5.2' package from nugget. Please guide me how to use your bug fix commit?

I haven't created a new package with the latest fix. The only way is to compile the project by yourself.

Our team has developed a project based on this package for 6 months, and now such a problem has occurred during delivery. Thank you for your efforts in developing this application package Please update the package. thanks.

v3.5.3 uploaded to nuget

Thank you very much.

GF-Huang commented 5 months ago

@ghost1372 How did you sync HC (HandyControl) to this repo (HCS - HandyControls)? I had try GitHub Pull Requests, it seems not supports PR from/to different repo. I want to merge some PR from HC into custom branch of my HCS fork and compile by myself.

GF-Huang commented 5 months ago

Oh I solve it. Just add HCS as new remote of HC in local git, then push PR branches to HCS.

GF-Huang commented 5 months ago

@ghost1372 How did you build from powershell? I got Error: Failed to install addin 'Cake.Git'..

image