search

ghostbar / angular-zxcvbn

Simple zxcvbn directive for Angular.js
MIT License
56 stars 10 forks source link

Improve unit testing by means of Saucelabs and CodeClimate #15

Closed evilaliv3 closed 8 years ago

evilaliv3 commented 8 years ago

When integrated the codeclimate token at https://github.com/ghostbar/angular-zxcvbn/compare/master...evilaliv3:fix/12?expand=1#diff-f9a62833538ab14fff849c2be16ab986R12 should be updated following https://docs.codeclimate.com/docs/setting-up-test-coverage

Let me know if you need any help in doing that.

The saucelabs token instead has been already created for the https://github.com/ghostbar/angular-zxcvbn/ repository so that it can remain the same.

ghostbar commented 8 years ago

Perfect! Thank you! I'll check it :)

evilaliv3 commented 8 years ago

The result will be the following:

screenshot from 2016-03-16 00 47 05

evilaliv3 commented 8 years ago

@ghostbar / @jamesclark92: as you can see from the travis/saucelabs output few tests are not properly working on IE10/IE11 so there showuld be a probably bug affecting them:

https://travis-ci.org/evilaliv3/angular-zxcvbn/jobs/116266856 https://api.travis-ci.org/jobs/116266856/log.txt?deansi=true

the logs anyhow git you a precise idea of what is failing and affectes IE10 and IE11 exactly on the same 4 tests:

IE 11.0.0 (Windows 10 0.0.0) zxcvbn attribute directive with extras attribute with form object should only pass non-null extras variables FAILED
    Expected '{"password":"password","score":2}' to equal '{"password":"password","extras":["[object Object]"],"score":2}'.
       at Anonymous function (/home/travis/build/evilaliv3/angular-zxcvbn/test/attribute-tests.js:115:7)

IE 11.0.0 (Windows 10 0.0.0) zxcvbn attribute directive with extras attribute with form object should detect a form field change and make another call to zxcvbn with the updated value FAILED
    Expected spy zxcvbn to have been called with [ 'password', [ 'test@example.com', 'jonskeet' ] ] but actual calls were [ 'password' ].
       at Anonymous function (/home/travis/build/evilaliv3/angular-zxcvbn/test/attribute-tests.js:129:7)
    Expected spy zxcvbn to have been called with [ 'password', [ 'test@example.com', 'chucknorris' ] ] but actual calls were [ 'password' ].
       at Anonymous function (/home/travis/build/evilaliv3/angular-zxcvbn/test/attribute-tests.js:134:7)

IE 11.0.0 (Windows 10 0.0.0) zxcvbn attribute directive with extras attribute with form object should detect when a form field has been added and recall zxcvbn with the added field too FAILED
    Expected spy zxcvbn to have been called with [ 'password', [ 'test@example.com', 'john_skeet' ] ] but actual calls were [ 'password' ].
       at Anonymous function (/home/travis/build/evilaliv3/angular-zxcvbn/test/attribute-tests.js:149:7)
    Expected spy zxcvbn to have been called with [ 'password', [ 'test@example.com', 'john_skeet', 'chucknorris' ] ] but actual calls were [ 'password' ].
       at Anonymous function (/home/travis/build/evilaliv3/angular-zxcvbn/test/attribute-tests.js:155:7)

IE 11.0.0 (Windows 10 0.0.0) zxcvbn attribute directive with extras attribute with form object should detect when a form field has been removed and recall zxcvbn without that field FAILED
    Expected spy zxcvbn to have been called with [ 'password', [ 'test@example.com', 'john_skeet', 'chucknorris' ] ] but actual calls were [ 'password' ].
       at Anonymous function (/home/travis/build/evilaliv3/angular-zxcvbn/test/attribute-tests.js:170:7)
    Expected spy zxcvbn to have been called with [ 'password', [ 'test@example.com', 'john_skeet' ] ] but actual calls were [ 'password' ].
       at Anonymous function (/home/travis/build/evilaliv3/angular-zxcvbn/test/attribute-tests.js:176:7)