search

ghostbsd / networkmgr

NetworkMgr is a Python GTK3 network manager for FreeBSD, GhostBSD, TrueOS and DragonFlyBSD
BSD 3-Clause "New" or "Revised" License
95 stars 30 forks source link

Fix logic error. #52

Closed mrclksr closed 3 years ago

mrclksr commented 3 years ago

if f'wlan{wlanNum}' not in (rcconf and rcconflocal):

Assuming rcconf is not None, only rcconflocal is checked if it contains wlan{wlanNum}. Concatenate lists with + to check both.

if f'wlans_{card}=' in (rcconf or rcconflocal):

Only rcconf is checked if it's not None. Concatenate lists with + to check both.

ericbsd commented 3 years ago

I can pull that in but netcardmgr to automate is deprecated in the later version. This code will be removed soon.

mrclksr commented 3 years ago

Thank you for merging, anyway :)