ghostbsd / networkmgr

NetworkMgr is a Python GTK3 network manager for FreeBSD, GhostBSD, TrueOS and DragonFlyBSD
BSD 3-Clause "New" or "Revised" License
95 stars 30 forks source link

rc.conf.local logic doesn't work as intended yet #53

Closed driesmp closed 3 years ago

driesmp commented 3 years ago

I'll investigate this myself, this is just a tracker so I remind myself. I think we might need to add some logic to net_api.py for rc.conf.local, eg in functions wired_card_added and wifi_card_added.

The reason that it doesn't work as intended for me yet is because I have defined all interfaces identically as networkmgr would've done in rc.conf.local, but it still writes to rc.conf.

ericbsd commented 3 years ago

There was a PR to fix that issue and the newest NerwotkMgr does not have that problem.

driesmp commented 3 years ago

I see, thanks. Could you push this fix to FreeBSD ports? Or are you waiting on the rework as you mentioned in the individual PR before creating a new tag.

ericbsd commented 3 years ago

I will I have some minor improvement that I want to get in, but I am not sure how FreeBSD users will like to have networkmgr override default devd entry.

ericbsd commented 3 years ago

Here is the file I am talking about https://github.com/ghostbsd/networkmgr/blob/master/src/setupnic.conf

driesmp commented 3 years ago

I did a quick scan, per FreeBSD hierarchy, this setupnic.conf file should go in /usr/local/etc/devd/. When I look at some other files present, maybe the correct naming convention should be networkmgr.conf, see image below.

image

Furthermore it seems that the default devd.conf in /etc/devd.conf already includes the wifi regex for us. image

I think the file is fine to ship as is for FreeBSD. It might be nice if you could check to remove the double wifi-regex definitions, maybe move them from this file to /etv/devd.conf in GhostBSD?

ericbsd commented 3 years ago

I was not aware if wifi-driver-regex of devd.conf would have work that is why I did add in setupnic.conf.

I remove it and test it when I get my improvement in.

ericbsd commented 3 years ago

That should do it https://github.com/ghostbsd/networkmgr/commit/c5c543db57dff1d2fbc47ab97f6cdd880ab9c29e

ericbsd commented 3 years ago

https://github.com/freebsd/freebsd-ports/commit/6022b5e24de357464bdb3db9b7863ad56bee3072

ericbsd commented 3 years ago

@driesmp feel free to open tickets if there any other problems.