search

ghostbuster91 / nvim-next

Apache License 2.0
29 stars 6 forks source link

Fix conditions for builtins #26

Closed devansh08 closed 1 month ago

devansh08 commented 1 month ago

This should fix the repeat behaviour for the f/F/t/T builtins (raised here: #24). As part of making this fix I have done some cleanup as well for logically unneeded conditions or arguments. Hopefully, this would make it easier to follow/debug the code.

This works fine on my local for the 4 builtins and custom mappings for both original and directional modes.

As a stretch I have also removed the seemingly (?) unneeded warning. As the warning was not behind any condition, nor could it be affected by any user config, I feel it should not be here. At least in the form it is now. Do let me know if there was any other idea behind it.

Let me know your thoughts. Thanks!

ghostbuster91 commented 1 month ago

This should fix the repeat behaviour for the f/F/t/T builtins (raised here: https://github.com/ghostbuster91/nvim-next/issues/24).

I wasn't able to reproduce the issue, so I cannot really test if this fixes anything as it was still working for me for some reason. Maybe a different nvim version? :thinking:

I tested your changes and it still works :+1:

As part of making this fix I have done some cleanup as well for logically unneeded conditions or arguments.

nice cleanup!

As a stretch I have also removed the seemingly (?) unneeded warning. As the warning was not behind any condition, nor could it be affected by any user config, I feel it should not be here. At least in the form it is now. Do let me know if there was any other idea behind it.

Yeah, I can't recall why I put it there. It doesn't make much sense :)

ghostbuster91 commented 1 month ago

Thanks for the PR! @devansh08

devansh08 commented 1 month ago

I wasn't able to reproduce the issue, so I cannot really test if this fixes anything as it was still working for me for some reason. Maybe a different nvim version? :thinking:

Honestly, after looking at the issue again now I realise what I saw in my local might not exactly match it 😅. For me basically both ; and , were going in the same direction, regardless of the repeat_style. Initially looking around led me to that issue and then after diving into the code I guess I lost context on what I started with. Just began trying to get it to fix my local 😁.

But regardless the default config does seem to behave as expected for me (and you), so all should be good! Hopefully, this fixes whatever issue #24 had as well.