Components - Githubissues

ghostdevv / jellycommands

A command handler for Discord.js

https://jellycommands.dev

MIT License

21 stars 6 forks source link

Components #183

Closed ghostdevv closed 2 weeks ago

ghostdevv commented 1 year ago

Now we are expanding beyond just commands/events to include buttons (#171) and soon things like modals (#182) it may make sense to not require a new directory per item.

Instead of

commands/
buttons/
modals/
...

features/

Name "features" is a work in progress, but seen it in other frameworks

Pros:

One place for all items
Less documentation needed

Cons:

Let me know any feedback/ideas

cainthebest commented 1 year ago

Possible suggestion for name: components

ghostdevv commented 1 year ago

Suggestion: app

ghostdevv commented 3 weeks ago

Revisiting this, I think the requirements are:

[x] Single directory in options (show in migration guide how to re-create old behaviour)
[x] All exports are checked rather than requiring the default
[x] Single "feature" (or w/e name is) class that items derive from, using a symbol to avoid instanceof. I think gives room for a potential plugins system in the future.

Name is still TBD

ghostdevv commented 3 weeks ago

After spending a lot of time writing the pr and calling it features I am used to it, but still doesn't feel right.

More ideas:

bits
pieces (sapphire uses this kinda)

I'm not sure what out of all the ideas in this thread I'm leaning to atm, so please share more ideas if anyone has any

ghostdevv commented 2 weeks ago

Decided to name it components, thanks for the suggestion cain!

ghostdevv commented 2 weeks ago

Added in #206, released in v1.0.0-next.44, migration guide here