ghostery / adblocker

Efficient embeddable adblocker library
https://www.ghostery.com
Mozilla Public License 2.0
786 stars 99 forks source link

ads showed with 1.30.0 version #4118

Open light2k4 opened 1 month ago

light2k4 commented 1 month ago

ads are showed with last version

chrmod commented 1 month ago

Hi there. Can you please elaborate? What is your setup? What pages are affected?

light2k4 commented 1 month ago

i use electron i have ads on Youtube

seia-soto commented 1 month ago

Hi @light2k4 ,

We currently have an issue with CSP on Electron. Due to this issue, dynamic script injections required to block ads on complex websites might not work.

https://github.com/ghostery/adblocker/issues/3819

We're planning to look into it after the urgent updates.

Thanks

seia-soto commented 1 month ago

Hi @light2k4 ,

I assume this is a filter problem. I cannot reproduce the issue at the latest revisions. If you can elaborate more, it'd be best: e.g. providing a repository that can reproduce the issue (with steps)

Thanks

light2k4 commented 1 month ago

https://github.com/light2k4/LightWeb

seia-soto commented 1 month ago

Hi @light2k4 ,

From your code, I could check you're using fromPrebuiltAdsAndTracking method to create an engine instance. The method will load the following filters:

const PREFIX =
  'https://raw.githubusercontent.com/ghostery/adblocker/master/packages/adblocker/assets';

export const adsLists = [
  `${PREFIX}/easylist/easylist.txt`,
  `${PREFIX}/peter-lowe/serverlist.txt`,
  `${PREFIX}/ublock-origin/badware.txt`,
  `${PREFIX}/ublock-origin/filters-2020.txt`,
  `${PREFIX}/ublock-origin/filters-2021.txt`,
  `${PREFIX}/ublock-origin/filters-2022.txt`,
  `${PREFIX}/ublock-origin/filters-2023.txt`,
  `${PREFIX}/ublock-origin/filters-2024.txt`,
  `${PREFIX}/ublock-origin/filters.txt`,
  `${PREFIX}/ublock-origin/quick-fixes.txt`,
  `${PREFIX}/ublock-origin/resource-abuse.txt`,
  `${PREFIX}/ublock-origin/unbreak.txt`,
];

export const adsAndTrackingLists = [
  ...adsLists,
  `${PREFIX}/easylist/easyprivacy.txt`,
  `${PREFIX}/ublock-origin/privacy.txt`,
];

This doesn't mean you can make a complain on those filter lists since we don't know if it's a filter-side problem or not at this moment. We're gradually catching up their functional requirement in those filter lists but not all the filters are not supported. Please, checke out the compatibility matrix in the following URL: https://github.com/ghostery/adblocker/wiki/Compatibility-Matrix . If you can check what filter is not working at the moment and what's the problem, please try to elaborate it here. We'll consider it as a plan to next release.

Especially, you need a stable reproducible example of a website and filter. We may not see the bug depending on the reproduction date and time.

Best