search

ghostery / broken-page-reports

9 stars 4 forks source link

foreignpolicy.com #352

Open GRadziejewski opened 1 year ago

GRadziejewski commented 1 year ago

Description: Sign in link do not work or is not visible.

Scenario 1: Steps to Reproduce:

  1. Open https://foreignpolicy.com/
  2. Click on "Sign in" Screenshot 2023-08-15 at 13 34 12

Scenario 2: Steps to Reproduce:

  1. Open https://foreignpolicy.com/
  2. Look for "Sign in" image

Expected Results: Webpage should work normally.

Versions:

Browser: Firefox 117.0b7
OS: Windows 10 Pro 19045.3208
GBE 8.11.1

Browser: Chrome 115.0.5790.171
OS: Windows 10 Pro 19045.3208
GBE 8.11.0

Browser: Opera One (101.0.4843.33)
OS: Windows 10 Pro 19045.3208
GBE 8.11.1

Browser: Edge 115.0.1901.200 (Official build) (64-bit)
OS: Windows 10 Pro 19045.3208
GBE 8.11.0

Browser: Safari 16.6 (18615.3.12.11.2)
OS: MacOS Ventura 13.5
GBE 8.11.2
philipp-classen commented 1 year ago

Seems to come from blocking GET https://cdn.tinypass.com/api/tinypass.min.js

Happens only in "block-all" mode (tinypass is covered by Piano, which is in "essential" category)

philipp-classen commented 1 year ago

I have to stop at this point. I see no wait to unbreak the page in block all mode by only adding exclusion rules. It is not a problem introduced by community lists, but I think it comes from trackerdb: https://github.com/ghostery/trackerdb/blob/fa448c7272cc01737829d21ec769ce0acfc21a00/db/patterns/tinypass.eno#L12

Since it is marked as essential, it will not be blocked by default. If it is enabled though, the request will be blocked and it will break the site. I am not aware of a way to prevent that; only by removing the tinypass rule from trackerdb, but that also means it will not be able to show the requests in the UI. Ideally, there should be a mechanism to configure detection and blocking independently.

philipp-classen commented 1 year ago

As an experiment, I disabled it only for this page: https://github.com/ghostery/trackerdb/pull/70

philipp-classen commented 1 year ago

As an experiment, I disabled it only for this page: ghostery/trackerdb#70

Rolled back the experiment. It did not solve the problem.

GRadziejewski commented 10 months ago

Both scenarios are reproducible.

Problem still occurs on:

Browser: Firefox 121.0
OS: Windows 10 Pro 
GBE 8.12.5

Browser: Chrome 120.0.6099.130
OS: Windows 10 Pro 
GBE 8.12.6

Cannot reproduce on:

Browser: Safari 17.2.1 (19617.1.17.11.12)
OS: MacOS Ventura 14.2
GBE 10.2.6