ghostery / broken-page-reports

7 stars 3 forks source link

usatoday.com #743

Open seia-soto opened 2 weeks ago

seia-soto commented 2 weeks ago

DO NOT include personal information. We're not responsible for personal information leakage in the report.

Website URLs

Please, list the website URLs having the issue in the following code block to prevent the potential leak of personal information.

https://www.usatoday.com/

Description

Describe your issue simple as possible. You'll need to describe how to reproduce the issue later.

USA Today is showing an Admiral popup with every page load.
Screenshots > Note that uploading any kind of artifacts via GitHub can be accessed without authentication. > > https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/attaching-files Paste or upload your screenshots here: ![image](https://github.com/ghostery/broken-page-reports/assets/30369714/880d71ef-c3a5-41e3-97ae-b6bb5d2b660c)

Steps to reproduce

Writing clear reproduction steps and environment helps us to recognize and identify the issue faster.

1. Open the website
2. Wait for the popup to be shown

Environments

Writing your environments detailed helps us to recognize and identify the issue faster.

If you're using Safari, you can replace the browser version with the OS version. Please, write in numbers.

OS/Browser: <independant>
Ghostery Browser Extension version: 10.3.12

If you have other extensions installed, please list them below. This is not a necessary step but multiple extensions running in the same site may cause conflicts.

Other details

Mike-E-angelo commented 2 weeks ago

Thank you very much for your efforts here @seia-soto 🙏

Mike-E-angelo commented 1 week ago

Hi @seia-soto are you able to say when this fix will be in by chance? For your awareness, this is still occurring as of today.

image

seia-soto commented 1 week ago

@Mike-E-angelo Sorry for the inconvenience, I found that another issue in the website. Admiral updated their domain. Blocking defensevest.com will solve the problem at the moment.

If you're using Ghostery Browser Extension v10, please go to "Privacy Protection" in our extension settings then click the version label for five times to enable custom filters:

||defensevest.com^
seia-soto commented 1 week ago

It's also being updated in EasyList by https://github.com/easylist/easylist/commit/fe400ff5c21a0083d30196f9777595753968ac5d , which means the update will be available in the next filter update.

Mike-E-angelo commented 1 week ago

Awesome! Thank you so much @seia-soto. I was making sure that this wasn't overlooked and I am very happy to see that you are on the case. 😎👍 Thank you again for all your diligence out there. It is greatly appreciated. 🙏

Mike-E-angelo commented 1 week ago

Heya @seia-soto FWIW I did apply the custom filter but that does not appear to solve this issue. Here is what I see:

image

Please let me know if I have something misconfigured. Thank you again for your efforts out there.

seia-soto commented 1 week ago

Hi @Mike-E-angelo ,

Sorry for the inconvenience. I found that another domain appeared on their side. Please, use the following filter instead:

||worldlever.com^

Admiral often registers multiple domains to avoid being detected. I hope the above filter helped!

Have a wonderful weekend.

Best

seia-soto commented 1 week ago

I found that this domain is added to EasyList 2 days ago: https://github.com/easylist/easylist/commit/fadbbabd75b3febcf7f622e2f26919de3897dee2#diff-56ec22c6c1f16ee4d805bb8a758a86e9dc5abd8f7b5e04b43c31174f0799a6e9R1969

Mike-E-angelo commented 1 week ago

Please, use the following filter instead:

Awesome! That did the trick @seia-soto 👍🙏

I found that this domain is added to EasyList 2 days ago

I do not know much about EasyList but I am assuming it is something that Ghostery uses. Are you able to say how long a change such as this takes to get propagated to Ghostery?

seia-soto commented 1 week ago

Hi @Mike-E-angelo ,

I'd like to say it normally takes up to 2 days due to delivery time mismatch in the community filter list and our internal system, and takes up to a week in case of an extension update is necessary.

Ghostery mixes various community filters and put the filters in this repository on the top of them. EasyList is the one of, or can be thought as the biggest ad-blocking filters' home. Their filters are consisted of commonly used filter syntax which includes the wide range of ad-blockers support, and our adblocker is also compatible with them (still some functionalities may result different).

For the delivery time of filters, it's actually hard to say the exact time. However, the latest changes of the filters on our CDN should available within 2 days in the commonly used environment. Especially, the whole update of filters can take up to a week in manifest version 3 due to the browser restriction. This is because the browser limits the number of network filters can be modified via programmatic API, which means that we need to ship an extension update to change the whole filters. This will happen rarely but there's a possibility.

So if I wrap up the things, the followings are the possible reasons of filter update delay:

So, Back to the conclusion, I'd like to say it normally takes up to 2 days due to delivery time mismatch in the community filter list and our internal system, and takes up to a week in case of an extension update is necessary.

I hope this answered your question and hope you to have a refreshing start of the week. Always many thanks for choosing Ghostery!

Best

Mike-E-angelo commented 6 days ago

Thank you for that incredibly valuable reply @seia-soto, it is greatly appreciated. One last question I have is... is there a way to determine the new domain that Admiral is using? e.g. worldlever.com or defensevest.com? That way I can add it to the filter instead of bugging you about it. 😊

(Or I guess, I can still report it as well to ensure you know about it 🤔)

seia-soto commented 6 days ago

Hi @Mike-E-angelo ,

Unfortunately, one of goals of those companies are to avoid being detected. They often mixes meaningless URL parameters and components, so it's hard to say exact rule that classifies the request by Admiral. However, still their requests should be recorded in the developer tools and it's easily distinguishable by human.

image

You can visit to the root domain to make sure you're blocking the right one.

Best

Mike-E-angelo commented 6 days ago

Awesome @seia-soto I will attempt to do this the next time that cat 🐱 attempts to catch this mouse 🐭 😅

FWIW as far as I am concerned this issue is resolved and can be closed. 👍

Mike-E-angelo commented 5 days ago

Looks like ||frogator.com^ is the latest... they are aggressive!

seia-soto commented 5 days ago

I created a PR on EL. Thanks.