yokoffing
commented
1 year ago @GRadziejewski Please assign + triage
Open yokoffing opened 1 year ago
yokoffing
commented
1 year ago @GRadziejewski Please assign + triage
philipp-classen
commented
1 year ago Confirmed. I also see ads on Firefox with Ghostery 8.9.9.
philipp-classen
commented
1 year ago The carousel type of ads are also not blocked:
yokoffing
commented
1 year ago This
! https://github.com/uBlockOrigin/uAssets/issues/16701
bing.com#@#.b_ad:remove()is in uBO Quick Fixes, which is one of the lists we need to match parity with uBO defaults, but I don't know if not having this rule relates anything to seeing Bing ads. The issue it references is related to Images within Bing.
I'll talk with @chrmod tomorrow about moving forward with https://github.com/ghostery/adblocker-filters/pull/827 and https://github.com/ghostery/adblocker-filters/pull/828.
philipp-classen
commented
1 year ago Nice finding. But note that :remove() is a feature that our adblocker engine currently doesn't fully implement. Eventually, we want to support it, but it will require some work.
The topic was first brought up in this issue: https://github.com/ghostery/broken-page-reports/issues/232#issuecomment-1400637183
yokoffing
commented
1 year ago The rule that was in Quick Fixes is no longer there, and I can't find a reference for it since it was removed. I assume something was modified in uBlock filters.
We need to check if AdGuard Base filter have a solution that doesn't require :remove() for the time being:
! https://github.com/AdguardTeam/AdguardFilters/issues/44788 - bing.com - it seems that bing.com is using some kind of ad reinjection script and displays different ads if below elements are blocked
! https://github.com/AdguardTeam/AdguardFilters/issues/116297
! 27.04.2022 - It looks like that website is checking "document.querySelector('li.b_ad').offsetHeight < 1 || document.querySelector('li.b_ad').offsetWidth < 1 || document.querySelector('li.b_ad').offsetLeft < 0" (and some other elements) and
! if it returns true, then ABDEF cookie is set to "V=13&ABDV=13" and then display a different ads, if returns false then to "V=13&ABDV=11" and ad reinjection is not called, if I'm not wrong
! bing.com##.sb_adTA
! bing.com###b_content > main > #b_results > li:not(.b_algo):not(.b_ans):not(.b_mop):not(.b_pag)
! bing.com#$?#.b_ad { remove: true; }
bing.com#@#.pa_sb
bing.com#@#.pa_carousel_mlo
bing.com#@#li.b_adBottom
@@||bing.com^$generichide
bing.com#$#body .pa_sb { display: block !important; position: absolute !important; top: -9999px !important; }
bing.com#$#body .pa_carousel_mlo { display: block !important; position: absolute !important; top: -9999px !important; }
bing.com#$#body .b_adLastChild { display: block !important; position: absolute !important; top: -9999px !important; }
bing.com#$#.b_ad { display: block !important; position: absolute !important; top: -9999px !important; }
bing.com#$?#.b_restorableLink { remove: true; }
bing.com###b_content > main[aria-label] > #b_ims_bza_pole
bing.com##.shop_page .br-poleoffcarousel
bing.com##.b_spa_adblock
bing.com###b_content > div#pole > div[class="ra_car_block ra_pole"] > div.ra_car_container
bing.com##.ins_exp.tds
bing.com###pole > .productAd[data-ad-carousel]
bing.com##.b_adPATitleBlock + div
bing.com##a.sb_meta[href^="http://advertise.bingads.microsoft.com"]
bing.com##.promotion-panel-innerBlocked in uBO and not in Ghostery
yokoffing
commented
11 months ago Some users are also reporting ads in Hotmail (outlook)?
yokoffing
commented
10 months ago Logs (blocked only)
Bing ads (reproduced on Firefox and Chrome)