ghostery / ghostery-extension

Ghostery Browser Extension for Firefox, Chrome, Opera, Edge and Safari
Mozilla Public License 2.0
1.4k stars 142 forks source link

[Ghostery Control Panel] create appealing landing for non-existing WTM Statistical report #1331

Closed mdsandu closed 8 months ago

mdsandu commented 1 year ago

we don't have the whole web in WTM, so many pages will not be found by users. let's make the landing visually appealing and informative for the user offering some of the new facts we created for WTM main page and linking out to somewhere to learn more about WTM

site like e.g. https://www.whotracks.me/websites/whotracks.me.html https://www.whotracks.me/websites/bisoubreton.com.html

starting point is:

Image

now landing looks like:

Image

chrmod commented 1 year ago

To avoid the current situation we should not show the link in the first place if we know there is no WTM page. We already are shipping a list of domain for which we have stats for the Trackers Preview. So I think it must be regression towards Ghostery 9. @smalluban can you take a look?

@mdsandu are you fine to solve the problem by removing the link when there are no stats? If so, then this is pure engineering task.

mdsandu commented 1 year ago

the button should be removed from the UI @chrmod

mdsandu commented 1 year ago

on a second thought I think it brings more value to leave the page there(even if there is a solution to remove it) and populate it with great stats, great info about WTM and use it as a resource for users to learn more about WTM if they go to the panel anyways)

smalluban commented 1 year ago

Ok, so I leave it as it is. For the record, earlier we were checking if the page is not 404, but with the https://github.com/ghostery/ghostery-extension/commit/5e2ac38a1520b69b5acbf0c8393985f77bed5c69#diff-a76932ae38751c82a862adaa5a488620ec81df9d0e049742a7af20d4d30b0e64L29 I removed that check (sorry, I can't remember why :P).

mdsandu commented 1 year ago

most probably you removed the check because to trigger the stats in the control panel and create that link behind the button, the page must be loaded in the browser...can it be?

kalinme commented 1 year ago

@mdsandu @smalluban how about something like this: https://www.figma.com/file/Ez4ZUl7q5yXVtAh17TZaOF/WhoTracks.Me?type=design&node-id=293%3A6817&mode=design&t=bp96HQK15bALaPde-1 ?

kalinme commented 1 year ago

new updates: https://www.figma.com/file/Ez4ZUl7q5yXVtAh17TZaOF/WhoTracks.Me?type=design&node-id=293%3A6817&mode=design&t=T5pZxlG2kEqyYVXA-1

kalinme commented 1 year ago

new version: https://www.figma.com/file/Ez4ZUl7q5yXVtAh17TZaOF/WhoTracks.Me?type=design&node-id=424%3A7215&mode=design&t=fkEX6NalaYYH9iqj-1

mdsandu commented 9 months ago

let's hold this off until the census report is picked by the media. we can proceed then

mdsandu commented 9 months ago

@kalinme the latest link is not working: https://www.figma.com/file/Ez4ZUl7q5yXVtAh17TZaOF/WhoTracks.Me?type=design&node-id=424%3A7215&mode=design&t=fkEX6NalaYYH9iqj-1 can you please update?

mdsandu commented 9 months ago

this became irrelevant AFAIK?

@kalinme @chrmod

kalinme commented 9 months ago

@mdsandu we need final decision about placeholder page. Discussion from yesterday: https://ghostery.slack.com/archives/C03MP7U2GJ0/p1709718902319209

mdsandu commented 9 months ago

AFAIR resolution was to check WTM data and not show the button when page is not in top 10K. correct me if I am wrong. but based on that this mini project became irrelevant

smalluban commented 9 months ago

We have already merged PR https://github.com/ghostery/ghostery-extension/pull/1498 which hides the button if the WTM stats are missing, so I think we can remove the placeholder page, and show ordinary 404 if the user enters an invalid URL.

AdamGhst commented 8 months ago
  1. Since there is no easy way for user to get on page that missess data, and button hides in ui when data is not avaiable, there is no reason to use missing page placeholder.

  2. Right now redirect to wtm main is set instead of 404.

smalluban commented 8 months ago

Done