Global pause feature - Githubissues

ghostery / ghostery-extension

Ghostery Browser Extension for Firefox, Chrome, Opera, Edge and Safari

Mozilla Public License 2.0

1.37k stars 139 forks source link

Global pause feature #1648

Closed smalluban closed 3 months ago

smalluban commented 3 months ago

Overview

Adds global pause feature. The feature uses a special ID to options.paused with 24 hours delay.

To disable Ghostery completely it turns off the following features:

Disables all DNR rulesets
Disables WebRequest reporter (anti-tracking)
Disables adblocker engines

Wording & UI

Added Main protection header (instead of Protection modules) - it fits more with the Further protection
Updated privacy UI with a toggle
Panel has new state - global pause - the main "trust/revoke" button has new action when the global pause is activated
Added temporary notification about the feature - I recommend removing it in the next release - so it will be kept for at least a week on production

chrome-extension___jccobfekniccmgppgbkonmdmdldhhgjc_pages_settings_index html(iPad Air)

philipp-classen commented 3 months ago

Since we are doing repeated linear scans over the paused array, I assume we are confident that it does not grow. Let's say, it stays under 50 entries or so, right?

Otherwise, we should consider switching to a set when holding it in memory.

mdsandu commented 3 months ago

I would remove title "Main protection" completely - the separator lines are already stating the different set up area
I would add another grey separator after Global Pause - that clarifies it more that it belongs to above but it has a deeper effect on your protection status
Pause in Global pause needs to be capitalized to be inline with the rest
there is an "i" in 23h 5 mins left - should that be "&", I would have no icons there

smalluban commented 3 months ago

there is an "i" in 23h 5 mins left - should that be "&", I would have no icons there

@mdsandu This is a "polish" artifact, I removed Polish from translations, but this time counter is generated by the browser, and it used polish internally, it will be different in English, sorry for misleading you.

smalluban commented 3 months ago

chrome-extension___jccobfekniccmgppgbkonmdmdldhhgjc_pages_settings_index html(iPad Air) (2)

Tweaked view @mdsandu (full English)

I added an image on the side, as without it, it looks ugly - I have used the pause icon, I hope you like it ;)

smalluban commented 3 months ago

@philipp-classen The options.paused is a list created by the user by hand - it might have more than 50 entries, but I suppose it rarely changes.

mdsandu commented 3 months ago

[x] Global Pause

Title: Global Pause —> Pause Ghostery Desc: Suspends privacy protection globally for 1 day.

[x] Panel - Bottom text:

Title (bold if possible): Missing the “Pause Ghostery” feature? Description (force new line): You can find it in your Privacy protection settings.

CTA: Open Ghostery settings

related - same page:

[x] Never-Consent Automatically rejects of cookie consent notices. --> remove "of"
[x] Search Engine Redirect Protection Prevent Google from redirecting search result links through their servers instead of linking directly to pages. --> change to "Prevents"
[x] Panel message Text: Ghostery is paused Button: Undo

github-actions[bot] commented 3 months ago

Builds for commit 7e42af98b5059f10d01208d6dd50da8ad96cec16: