Trusting vs Pausing - Githubissues

ghostery / ghostery-extension

Ghostery Browser Extension for Firefox, Chrome, Opera, Edge and Safari

Mozilla Public License 2.0

1.35k stars 139 forks source link

Trusting vs Pausing #1716

Closed chrmod closed 1 week ago

chrmod commented 3 weeks ago

Decisions to make:

[x] naming - "Trust this site" stays
[ ] colors - change to functional color yellow in ON state
[x] time options - remain in existing order
[ ] update explainers on the time options This site will be trusted for 1 hour This site will be trusted for 1 day This site will always be trusted. You can change this at any time in Ghostery settings to stop trackers and ads from tracking you around the web.

GRadziejewski commented 2 weeks ago

Trust_vs_pause_site_decision_helper.pdf

smalluban commented 2 weeks ago

There was no "yellow" color in the Ghostery Panel Design System. I took one from the Ghostery Web Design System - warning-500. However, the color is too light to use white text color, I switched to gray-800.

Please confirm the choice.

smalluban commented 2 weeks ago

I think the contrast here is bad... especially on the toggle. However, in that subject, I would re-think if we should switch completely to the normal toggle, which applies the "exception", not a "trusted/blocked" one.

smalluban commented 2 weeks ago

I made a draft PR with a package label. You should be able to test out the current changes on your machine if this is better for you..

GRadziejewski commented 2 weeks ago

Yellow - it looks wrong. The previous colour - green, looks much better.

I have found something like this: https://www.figma.com/design/0HIwg2OfZmw4hKyVl6f7kQ/Ghostery-Panel?node-id=1871-11148&t=x4Qjug7NEldzyA0i-4 From which, maybe the blue colour would be good for the pause state?

Or we can go with this orange colour: https://www.figma.com/design/ZDePWBimq04bD90s3QkaC3/Ghostery-Prototypes?node-id=1-57&t=x4Qjug7NEldzyA0i-4

Or, we could go with some colour from our website colour palette: https://www.figma.com/design/bDQ8eglnrxg8O4lpqPXwai/Ghostery-Web-Design-System?node-id=9-611&t=x4Qjug7NEldzyA0i-4

philipp-classen commented 2 weeks ago

The yellow in the PR would be okay for me, but I do not hold a strong opinion.

One comment unrelated to the color. When switching back and forth between simple and detailed view, the page loses its trusted state. Perhaps it is expected in this PR (to only show the visuals); if not, these would be steps to reproduce:

Go to any page (e.g. spiegel.de)
Go to detailed view
Trust any activity (e.g. Google Tag)
Trust this site (Now the Site is trusted and yellow)
Go to simple view (Now the Site is no longer trusted)

smalluban commented 2 weeks ago

I found when working on regional filters that somehow nested records might be cleared. I suppose this is a bug. Working on it.

However, this is only on main (not yet released).

smalluban commented 2 weeks ago

@philipp-classen I made a fix in hybrids - https://github.com/ghostery/ghostery-extension/pull/1737

philipp-classen commented 2 weeks ago

@philipp-classen I made a fix in hybrids - #1737

Confirmed. That fixes it.