search

ghostery / ghostery-extension

Ghostery Browser Extension for Firefox, Chrome, Opera, Edge and Safari
Mozilla Public License 2.0
1.39k stars 142 forks source link

Exception is not visible on Trackers and Websites tab #1780

Closed GRadziejewski closed 3 months ago

GRadziejewski commented 3 months ago

Description There is a problem with adding the exception for the website, it's not visible right after the change.

Frequency 8/10

Steps to Reproduce

  1. Open any website, for example https://www.espn.com/

  2. Open Ghostery panel no Detailed view

  3. Open details for any tracker, for example Adobe Audience Manager

  4. Click on "Blocked on all websites" button to open protection status

  5. Click on "Trust on this website" button

  6. Go back to the tracker details and click on the cog wheel

  7. Ghostery Settings should be open with focus on this tracker details image

  8. Newly added exception is missing

  9. Open Websites tab - newly added exception on the website from step 1, is missing image

  10. Refresh the site

  11. Exception is visible on Trackers and on Websites tabs

https://github.com/user-attachments/assets/08171ffd-044f-4f59-bb22-c1d2d0d395f9

Expected results After adding the exception, it should be visible right away on the Websites and Trackers tab

Versions

Browser: Chrome 127.0.6533.89
OS: Windows 10
GBE 10.3.16

Browser: Safari 17.6 (19618.3.11.11.5)
OS: macOS 14.6 (23G8Q)
GBE 10.3.16

Browser: Firefox 128.0.3
OS: Windows 11
GBE 10.3.16
smalluban commented 3 months ago

This is not a regression (works like this on v10.3.15 on prod) and more importantly, this is not a bug - the exceptions have their own place in the local storage, and for purpose updates of those don't trigger updates of models kept in the memory in another cotexts in the UI only - background process has that and updates correctly to the current state of the UI.

The only drawback is that the panel can have a newer state than already opened Settings page. However, this code is going to be refactored to be a part of Options - so the behavior will disappear.