search

ghostery / ghostery-extension

Ghostery Browser Extension for Firefox, Chrome, Opera, Edge and Safari
Mozilla Public License 2.0
1.39k stars 142 forks source link

Update vite #1867

Closed chrmod closed 2 months ago

chrmod commented 2 months ago

The builds starts just fine so maybe we don't need to patch vite anymore.

smalluban commented 2 months ago

Normally, it would not be a problem, but we have "external" configuration of the i18n - which must be called before anything else.. This is why the panel package must be loaded before components generated by static imports.

chrmod commented 2 months ago

@smalluban got it. I've brought back the patch. This is however a very esoteric knowledge. Do you think we can remove this special patching once the "monorepo" is gone?

smalluban commented 2 months ago

I think we will, the thing is very special, as our needs are special. As the code was shared between packages/extensions.. it must have been like that.

chrmod commented 2 months ago

I'm fine to do it later, but not that old vite trigger security warning from npm.