ghostery / ghostery-extension

Ghostery Browser Extension for Firefox, Chrome, Opera, Edge and Safari
Mozilla Public License 2.0
1.4k stars 142 forks source link

fix(setup): remove hard threshold in async setup #2075

Closed smalluban closed 2 days ago

smalluban commented 3 days ago

We received several user feedback logs, where the threshold of 10 seconds was exceeded. As there is no way to prove how it should be set, we should allow waiting for promises to be resolved.

This PR keeps the threshold, but only for warning in the console, that some of the promises did not resolve. I added the id argument to make the log more helpful.

I tested a synthetic case with a delaying setup, as well as, throwing an error. The errors are logged in the console correctly, as they are caught in different contexts. It is sufficient to re-throw errors.