ghostery / ghostery-extension

Ghostery Browser Extension for Firefox, Chrome, Opera, Edge and Safari
Mozilla Public License 2.0
1.38k stars 140 forks source link

Ghostery extension blocks network calls to `*.onetrust.com/*` when Ad blocking is enabled #804

Closed abhisheksd1008 closed 2 years ago

abhisheksd1008 commented 2 years ago

Description

Ghostery extension blocks network calls to *.onetrust.com/* when Ad blocking is enabled, even though OneTrust is categorized as Essential in the WTM database. This is blocking Privacy Policy content for a number of sites.

Expected Behavior

Network calls are not blocked so that Privacy Policies can be rendered on the site's Privacy Policy page.

Actual Behavior

Network Call is blocked, so content cannot be served.

Steps to Reproduce

  1. Navigate to https://onetoso.com/SE/otkicks/privacy-policy.html
  2. Observe that page is not rendered
  3. Turn off the Ad category and refresh
  4. Observe that the page is rendered properly

    Versions

    • Browser: Vivaldi 5.2.2623.46 (Stable channel) (x86_64)
    • OS: macOS Monterey 12.4
rayray-asmar commented 2 years ago

Hello, Can you please share an update with us ? We are waiting for this fix as it's a blocker for us.

Thank you, Best

Ray Al Asmar L'Oréal Goup - Global IT Project Manager ray.alasmar@loreal.com

rayray-asmar commented 2 years ago

Hello, kind reminder to get an update. Thanks

Ray L'Oréal Goup - Global IT Project Manager ray.alasmar@loreal.com

philipp-classen commented 2 years ago

It is related to https://github.com/ghostery/ghostery-extension/issues/768 and we are working on a solution in https://github.com/ghostery/ghostery-extension/issues/783

From my understanding, it should fix the breakage related to blocking OneTrust. I'm linking it, so we don't forget it in our tests.

rayray-asmar commented 2 years ago

Thank you for this update, this is good news :) Do we have visibility on the planning of delivery ? Ray

philipp-classen commented 2 years ago

Reopening (it was automatically closed by merging a potential fix).

I will leave it open until it is confirmed that a fix is live. It may take a bit until the filter lists get updated.

@rayray-asmar I'll let you know when it is ready to test.

rayray-asmar commented 2 years ago

Thank you very much. I'll be keeping an eye on it. Thanks ray

philipp-classen commented 2 years ago

With the latest blocklists, the test site https://onetoso.com/SE/otkicks/privacy-policy.html should be no longer broken:

onetoso

@rayray-asmar Please have a look. To refresh the block lists, you can use "Settings -> "General Settings" -> "Update now" (right side under trackers). We will do more testing over the upcoming days to fix other web sites where the consent dialogs are broken. But if you notice a problem, please let us know. Thank you for your help!

rayray-asmar commented 2 years ago

Hello, Thank you for your help fixing this. I will run some tests and get back to you. Thanks ray

rayray-asmar commented 2 years ago

Hello, I do confirm that the One Trust content is not blocked by Ghostery anymore. Thank you very much. Ray

rayray-asmar commented 2 years ago

Hello @philipp-classen I saw another blocker today : when you have ghostery blocking the Ads, you dont have to interact with the one trust cookie banner to interact with the website. Whereas, if you deactivcate your ghostery blockin ad, you cannot interact with the website before you interact with the one trust banner. you can see this on lancome.co.uk wesbite.

Can you check this out ? Thanks Ray

philipp-classen commented 2 years ago

Let me reopen it, but personally I could not reproduce. With or without adblocking, I get always both consent dialogs (same as in Firefox without Ghostery):

lancome

Do you know what I'm missing? Please share the steps to reproduce and we will look into it.

rayray-asmar commented 2 years ago

Hi, thanks for your prompt reply. @philipp-classen try to close the pop-up that is behind the cookie banner then you'll be able to interact with the website and navigate through the pages before interacting with the banner. thanks ray

philipp-classen commented 2 years ago

Thanks, now I get it. Yes, I can confirm that (without Ghostery, it is a modal dialog, but Ghostery changes that behavior).

rayray-asmar commented 2 years ago

thanks ! what would be the next steps ?

Thanks ray

philipp-classen commented 2 years ago

thanks ! what would be the next steps ?

Thanks ray

@rayray-asmar We will try to fix it. I also created a ticket here, where we keep track of broken pages now: https://github.com/ghostery/broken-page-reports/issues/71

rayray-asmar commented 2 years ago

Thank you very much @philipp-classen Please keep me updated on the fix. Best Ray

chrmod commented 2 years ago

@rayray-asmar @abhisheksd1008 now that we've started a rollout of our new featuer Never-Consent, Ghostery no longer blocks requests to onetrust.com.

Please confirm if the website breakage is gone.

rayray-asmar commented 2 years ago

Hello @chrmod 2 issues remain when ghostery is on :

The issues were raised here : https://github.com/ghostery/broken-page-reports/issues/71

I checked now and these 2 issues are still happening .

Thanks Ray