search

ghostery / user-agent-desktop

Ghostery Desktop Browser
Mozilla Public License 2.0
108 stars 16 forks source link

Customize Mascots (In error pages) #180

Open remusao opened 3 years ago

remusao commented 3 years ago

On some error pages (like when browser cannot load a page), a custom mascot is shown. For example: https://github.com/cliqz-oss/browser-f/blob/master/mozilla-release/browser/themes/shared/illustrations/error-connection-failure.svg

Maybe we could have Ghostery versions of those?

Example of place where this can be done: browser/themes/shared/aboutRestartRequired.css https://github.com/ghostery/user-agent-desktop/blob/8f59bd745702f7c76f97bc3d67472577824ac644/browser/themes/shared/aboutRestartRequired.css#L33

Or https://github.com/cliqz-oss/browser-f/blob/master/mozilla-release/browser/themes/shared/illustrations/error-session-restore.svg

I guess we can check everything in folder browser/themes/shared/illustrations/?

image

chrmod commented 3 years ago

Nice finding. Wonder why those assets are not in the theme. Probably because they are shared by all brands.

It would be interesting to check if brandings assets override this ones.

Anyways, it is nice to have.