ghostery / user-agent-desktop

Ghostery Desktop Browser
Mozilla Public License 2.0
120 stars 17 forks source link

Customize Browser Version on Windows #183

Open remusao opened 4 years ago

remusao commented 4 years ago

config/version_win.pl https://github.com/ghostery/user-agent-desktop/blob/8f59bd745702f7c76f97bc3d67472577824ac644/config/version_win.pl#L116 https://github.com/ghostery/user-agent-desktop/blob/8f59bd745702f7c76f97bc3d67472577824ac644/config/version_win.pl#L238 (used to be Mozilla Foundation) https://github.com/ghostery/user-agent-desktop/blob/8f59bd745702f7c76f97bc3d67472577824ac644/config/version_win.pl#L239 (used to be Mozilla)

chrmod commented 4 years ago

related: https://github.com/ghostery/user-agent-desktop/pull/119 - maybe it should be the same patch

chrmod commented 4 years ago

Should we try to use preprocessor to inject values into those files? Then such change can be send upstream.

sammacbeth commented 4 years ago

This perl file has moved to python, and it looks like we can customise the windows version with build configs: https://searchfox.org/mozilla-central/source/config/create_rc.py#129

On the current build the version number mostly displays correctly, so I'll push this to the backlog.