search

ghostery / user-agent-desktop

Ghostery Desktop Browser
Mozilla Public License 2.0
120 stars 17 forks source link

Update Windows widget folder #197

Open remusao opened 4 years ago

remusao commented 4 years ago

Replace Mozilla with Ghostery? Do we need that? widget/windows/WinTaskbar.cpp widget/windows/nsWindowDefs.h

chrmod commented 4 years ago

In WinTaskbar browser Mozilla is hardcoded in the windows registry path. Instead of hardcoding we could read vendor property from appInfo and submit patch to upstream.

The second one seems to be pretty important for Windows users: https://github.com/cliqz-oss/browser-f/commit/9c3a417ccf117f4ae4f49f31ceea01e79f5a9941

sammacbeth commented 4 years ago

I'm not sure the purpose of this registry entry. I tried to trigger it being set but could not. On my system the values at Registry key Mozilla/Firefox/TaskBarIDs (which this code seems to be reading/writing) seems to be multi-install aware, so I doubt it would cause a conflict with Firefox. Screenshot 2020-09-23 133936

chrmod commented 4 years ago

Can this be covered by https://github.com/ghostery/user-agent-desktop/issues/176 ?