ghostfolio / ghostfolio

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍
https://Ghostfol.io
GNU Affero General Public License v3.0
3.79k stars 355 forks source link

Feature/improve error handling in biometric authentication registration #3496

Closed juanabascal closed 1 week ago

juanabascal commented 1 week ago

Fixing #3453.

My guess is that somehow authn support is not enabled in the user's browser. I manually disabled authn in Firefox and I was able to get the same experience as the user.

To disable Authn:

I have done a two-way solution:

  1. Disable fingerprint login if Authn is not supported by the browser
  2. In case of an error during fingerprint login set up, uncheck the toggle and show a snack message.
juanabascal commented 1 week ago

@dtslvr addressed the comments. Let me know what you think.