ghostfolio / ghostfolio

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍
https://Ghostfol.io
GNU Affero General Public License v3.0
3.83k stars 359 forks source link

Revamp Holdings screen to show investment value #477

Open I-Valchev opened 2 years ago

I-Valchev commented 2 years ago

One of the areas that's missing is the total current value of an investment on the Holdings screen. Here's a way to show it without overcrowding it:

image

Logo is optional, though I kinda like the more visual effect :-) It's a bit motivating also to see the logos of the companies you've put your money in 😁

Happy to take a look into implementing this... though not sure what API ghostfolio is using behind the scenes and if there's an easy way to grab the logo

dtslvr commented 2 years ago

Hello @I-Valchev

Thank you for your suggestion. Generally I like the idea, but I have some questions.

I-Valchev commented 2 years ago

Hey @dtslvr

My replies are in bold

Hello @I-Valchev

Thank you for your suggestion. Generally I like the idea, but I have some questions.

  • How would it look like for longer names of typical ETFs? Here is an example: Xtrackers (IE) Plc - Xtrackers MSCI World UCITS ETF 1C (XDWD.DE) Show as much as possible, then cut off with ellipsis. The tracker is still visible.
  • How would it look on smartphone? On my device, the width is only as much as the date range buttons Perhaps the same as it does right now, only with the total value included?
  • What logo would you show for ETFs? Ha, not sure. Maybe the ETF provider logo? IMHO, the logos are "nice to have" while the total value is something that is actually harming the experience
  • The data provider does not have a logo in place. I think an additional one like https://brandfetch.com would be needed via the data enhancer mechanism