Closed NayamAmarshe closed 1 year ago
Are you sure kill by pid does not work post-merge? Please refresh your sources try again. Also, if it still won't work for you, please provide your system details (distro, DE, etc.). For me (LM 20 x64 / Cinnamon), kill by pid works fine.
Generally speaking, pkill
is too much of a sledgehammer method, which is why I removed it (or a similar method; can't remember) from the original video-wallpaper.sh
and shifted the script towards kill by pid. If you use pkill
, it will kill all instances of mpv
, including those the user still wanted to keep running (e.g. for music or video playback).
One more minor niggle: You've duplicated code in your pull request; the start()
function should not kill mpv and xwinwrap itself, but instead invoke the stop()
function.
Are you sure kill by pid does not work post-merge? Please refresh your sources try again. Also, if it still won't work for you, please provide your system details (distro, DE, etc.). For me (LM 20 x64 / Cinnamon), kill by pid works fine.
Generally speaking,
pkill
is too much of a sledgehammer method, which is why I removed it (or a similar method; can't remember) from the originalvideo-wallpaper.sh
and shifted the script towards kill by pid. If you usepkill
, it will kill all instances ofmpv
, including those the user still wanted to keep running (e.g. for music or video playback).One more minor niggle: You've duplicated code in your pull request; the
start()
function should not kill mpv and xwinwrap itself, but instead invoke thestop()
function.
I'll try the new commit and let you know. The pid method was not working on my ZorinOS installation.
Currently, the kill by pid doesn't seem to work. I don't know if my method of using pkill with the names of applications is better or not, but it does seem to work just fine. This makes sure that multiple instances of mpv and xwinwrap do not spawn, which was a problem earlier.