search

ghostlydilemma / openttd-jgrpp

OpenTTD JGR's Patchpack Docker Container
3 stars 3 forks source link

Logs not printing through golang console and server not controllable - dumb-init issue? #3

Closed willnwalker closed 6 months ago

willnwalker commented 1 year ago

When using the provided docker-compose.yaml file with Docker Desktop on Windows using WSL 2 backend the below config no longer proxies server messages to the console and the console cannot be used to change settings on the running OpenTTD server within its separate container.

version: '3'
services:
    openttd:
        image: ghcr.io/ghostlydilemma/openttd-jgrpp:0.54.4
        ports:
            - "3979:3979/tcp"
            - "3979:3979/udp"
        volumes:
            - "//c/Users/<user>/Documents/OpenTTD:/home/openttd/.local/share/openttd/"
        restart: always
        environment:
            PUID: "1000"
            PGID: "1000"
            loadgame: last-autosave

    console:
            image: golang
            command: sleep infinity

The process and group user IDs were that of my WSL 2 user, and the Docker Desktop service was re-registered and verified.

Docker Engine v24.0.5

willnwalker commented 1 year ago

It looks like this may be due to the container command script (openttd.sh) containing a hashbang: #!/bin/sh

Could the process for the shell instead of the OpenTTD process become associated with the init background daemon?

ghostlydilemma commented 7 months ago

Heya, sorry, this issue must have completely slipped under my radar... I haven't used Docker on Windows in years, so reproducing the issue on my end may be a little tricky - I noticed that you invited me to a repo some time ago, were you able to get the issue fixed there?

On another note: I do remember the process of getting the console to properly work, even on Linux, to be quite involved and I sadly don't quite remember it anymore. I'll try to dig through my former server setup and maybe I can even try to improve the scripts here.

I tend to be quite busy though so no promises that that'll happen soon, I just happened to pick up OpenTTD again for the moment :sweat_smile:

katlyn commented 7 months ago

Hey @willnwalker, this is actually due to a slight misunderstanding in how the containers work. The server logs are printed from the openttd container, whereas the console container was just meant to be a sidecar container to easily run openttd-admin - this wasn't clearly communicated in documentation though. I've submitted a PR #9 that instead bundles openttd-admin with the image and clarifies usage a bit.

ghostlydilemma commented 6 months ago

Heya @willnwalker, I just merged the PR mentioned above, if you have further questions or problems feel free to reopen this issue :)

willnwalker commented 6 months ago

Hey @willnwalker, this is actually due to a slight misunderstanding in how the containers work. The server logs are printed from the openttd container, whereas the console container was just meant to be a sidecar container to easily run openttd-admin - this wasn't clearly communicated in documentation though. I've submitted a PR #9 that instead bundles openttd-admin with the image and clarifies usage a bit.

Thanks for the clarity, I thought I was missing something! I did notice that the go container was just sitting there, not wired to anything. Thanks for this latest PR!

@ghostlydilemma If you're still into the game check out the jgr server channels in the official discord

Those container instances are deployed using https://github.com/pterodactyl "eggs", punnily called yolks: https://github.com/pterodactyl/yolks