search

ghostnguyen / HttpClientFillerIssue

MIT License
11 stars 1 forks source link

IsAotCompatible flag missing? #3

Open michael-hawker opened 1 month ago

michael-hawker commented 1 month ago

Your readme mentions AOT compatibility, but then the project doesn't enable the analysis flag, see the docs here: https://learn.microsoft.com/dotnet/core/deploying/native-aot/#aot-compatibility-analyzers

And a helpful article on resolving any warnings: https://devblogs.microsoft.com/dotnet/creating-aot-compatible-libraries/

ghostnguyen commented 3 weeks ago

I will enable the flag in the next release. Currently, the code still works for AOT. I also push the test aot project in repo.

<PropertyGroup>
  <IsAotCompatible Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net7.0'))">true</IsAotCompatible>
</PropertyGroup>