Not all features working and setting page is empty

[ghostscript3r]

Issue for at least 3 users and signaled from ThorTheGray

First thing to check is javascript errors.

ThorTheGray hit F12 then click console and send me a screenshot of what you have there (ngtrungkhanh and SingleInfinity too if you can)

If you have problems doing or sending the screenshot hot CTRL-A and CTRL-C to copy all text, but it will be harder to read.

[ThorTheGray]

It seems i only have one error.

[ngtrungkhanh]

I have same problem.

[ghostscript3r]

Doesn't make much sense yet. Can you try edit the script and at line 28 change DEBUG from false to true. Save and refresh the page. You should see on console a lot of text. Send me that screen shot, it should give me some indication of where it's not working

[ngtrungkhanh]

Not sure if i did it right or not.

[ghostscript3r]

Yes you did it exactly right. But doesn't make sense yet. It seems to stop for a page error, but that should mean that at least some functions of the original page shouldn't work too.

I'll try to reproduce it but it's not easy.

I'll get back at you as soon as I have something to let you try for me.

Il sab 20 lug 2019, 10:28 ngtrungkhanh notifications@github.com ha scritto:

[image: image] https://user-images.githubusercontent.com/39927526/61576322-ed3d1b80-ab02-11e9-8203-5a0ebd99dd7b.png

Not sure if i did it right or not.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ghostscript3r/poe-trade-enhancer/issues/1?email_source=notifications&email_token=AMQRG2GNMMGJGDEOGI34HJTQALECJA5CNFSM4IFDSH32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2NJUCY#issuecomment-513448459, or mute the thread https://github.com/notifications/unsubscribe-auth/AMQRG2B33QL6NLCFBQBRJY3QALECJANCNFSM4IFDSH3Q .

[ghostscript3r]

Ok, please disable the script and install this one: https://www.dropbox.com/s/i7ttja8zqi9evz8/poe-trade-enhancer.user.js?raw=1 it's the one I use to develop new features. Run once with this and send me the screenshot (debug is already true) Then set DELAY to 5000 (row under DEBUG) and run it again. Give it few seconds because the script will start after 5 seconds and then send me the screenshot.

thx for taking the time to help debug it

[ngtrungkhanh]

[ghostscript3r]

Updae the DEV script (you should see 1.1.30 as version) and send me the screenshot. We should be near finding the problem

[ngtrungkhanh]

This was tested in my other computer, same chrome account, different window version, different network.

[ngtrungkhanh]

Here with ublock disable

[ngtrungkhanh]

BTW, i had teamviewer installed, in case you need.

[ghostscript3r]

At least I know what's wrong now, the iframe on load event doesn't fire. I'll search for a known solution because the code I used is the only guaranteed to work also in firefox. I'll have to get back to it in about ten hours though. If you are available then teamviewer might be very useful, because I can't reproduce the problem on any of my chromes.

[ghostscript3r]

Try to update again (1.1.31). This should work, but not in firefox

[ThorTheGray]

Just woke up and tried again. I still get nothing in the settings panel but it seems to be working for searches.

Edit: The buttons to save searches do nothing as well.

[ngtrungkhanh]

I got the same result as ThorTheGray

[ghostscript3r]

Can you try again updating the dev script? If I'm right now it should work, but I'll need to try some other solution because this way I'm sure it doesn't work in firefox

[ThorTheGray]

Seems I now can see settings however saving a search produces errors.

[ghostscript3r]

I need teamviewer for this... can't reproduce this even using your search exactly Do you have it? If so PM me your ID. If not try clicking on ":1965" (the first link inside the error block) and send me a screen of where it opens

[ThorTheGray]

Not familiar with teamviewer but I included where 1965 goes.

[ngtrungkhanh]

I need teamviewer for this... can't reproduce this even using your search exactly Do you have it? If so PM me your ID. If not try clicking on ":1965" (the first link inside the error block) and send me a screen of where it opens

Tell me your email, (tempmail is ok,) so i can send my id/pass Githut dont have private message feature

[ghostscript3r]

Sorry, thought my mail was already visible. ghostscript3r@gmail.com Before that try out new version 1.1.38, it might be a long shot, but might work. I have another one to try before teamviewer if this doesn't work

[ThorTheGray]

I can verify that 1.1.41 is seemingly fully operational.

[ngtrungkhanh]

Same here

[ghostscript3r]

encouraging at least, but this version have problems for me that I didn't have before, using chrome too.

can you check few things for me: do you see other userscript errors? autocomplete in save window works? renaming a search in load window shows a modal and the renaming works? in both save and load close button works? if you edit the script and remove line 8 (// @connect poe.ninja) does everything still work?

[ThorTheGray]

If you mean by does the search autocomplete which saved search you are looking for then yes. Renaming a search worked for me in the Load screen. Both close buttons do what they are intended to do. I haven't tried modding the script as I am unsure on how to do so.

[ghostscript3r]

Can you upgrade and confirm that 1.1.52 still works for you? This works for my chrome and for firefox, and should work for you too. I'll publish this version as soon as one of you confirm me it's working

[ghostscript3r]

Can someone test it? I can't reproduce it so I can't test it myself

[ThorTheGray]

I'll verify when I get home from work.

[ngtrungkhanh]

Sorry for late reply. It worked for me. But i had found a bug. Here is the first search. After i clicked "7 more from same user" - i still see IGN: Sofa_king..... (6 more hydraTheking is below) After i clicked "7 more from same user" one more time, hydraTheking disappear (he is put lower - at 6th)

[ngtrungkhanh]

http://poe.trade/search/ihiononakamudu link of the search

[ThorTheGray]

I could not test it last night since I had a power outage. Will test tonight.

[ghostscript3r]

ngtrungkhanh from what I'm seeing it's working as designed. Still the design might be improved :) what I mean is when results are grouped they are sorted by average price of all element in group. This is because I usually use only for maps and similar, things I'd like to buy in bunch but mostly at same price. It doesn't work very well with complex item searches where every item can have completely different price, but also completely different mods. When you ungroup it sorts for real poe.ninja value, so if you don't auto sort for that it should sort for original poe.trade order. That could be improved for sure.

[ghostscript3r]

I'd say it's working, I'm pushing a new release with the fix. You should stop using the dev one then. I'm going to some developments in the next and that can brake anytime and also stay broken for days.

[ThorTheGray]

I updated to the non-dev version and it seems to be ok.

[ghostscript3r]

Thank you very much to everybody