ghostscript3r / poe-trade-official-site-enhancer

UserScript that adds tons of usefull features to www.pathofexile.com/trade
68 stars 10 forks source link

"Might be a search for an old league", many searches not working. #10

Closed leet0rz closed 4 years ago

leet0rz commented 4 years ago

Ive remade this multiple times in the correct league and its still giving failed. This happens to other searches too.

https://i.imgur.com/qzAdIb8.png

More errors from multiple different searches with different search amounts: https://i.imgur.com/UIkO5Iz.png https://i.imgur.com/cUlgmyW.png

ghostscript3r commented 4 years ago

"Might be a search for an old league" is the error I print when the server consider the search not valide, and since the only case I've been able to systematically reproduce is a search with an old league I used that message. It might be another error, but it might be your IP is getting blocked for too many requests (from the images you run a lot of searches). To verify this if you have access to a VPN try to pass through that. Also if you attach the export of your searches I can check if there's something wrong in them. Do the same searches work if just loaded (non live)?

leet0rz commented 4 years ago

They do work if I load them singularly yeah. Its the only search Ive got open, I can open multiple live searches on my own in a different browser without problems.

Azdingo commented 4 years ago

Did you just give your whole flipping strategy?

leet0rz commented 4 years ago

Did you just give your whole flipping strategy?

That is not even 1/10th of it and it changes every league so good luck following me.

leet0rz commented 4 years ago

Not sure what happened but I commented and closed it, reopened it now.

ghostscript3r commented 4 years ago

One of 2 things is happening to you: 1- you are not logged in (live search can only be performed if logged in). From your screenshots it shouldn't be your problem, but I had this problem myself testing your searches and at least I found an error that need to be taken care differently

2- you are having the problem some others had, that is too many connections from the same IP address. Even if you use multiple browsers you arrive on the server with same user and same IP address. They can do the math. If you wish to open 800 connections they will never let you do that. The only way you could do this is using multiple VPN so you can arrive with different IPs, and maybe even use multiple accounts. The support answered me yesterday and the should be safe in matters of behaviors (if search gives an error it is not constantly retried, which would result in a temporary ban, same thing if you are not authorized, like in case 1 above). An alternative if you need 800 websockets would be using poe.trade. As far as I know they didn't implement a ban mechanism yet. I have to say though, this is not what the tool was meant for. I don't have anything against flipping, it just is the wrong implementation. Any sniper should get the very big json produced by the official API and parse that against your specific rules. Using this tool is the most server resource expensive solution possible (https://www.patreon.com/posts/poe-trade-is-not-33734746). Anyway to confirm this is your problem you should press F12 in chrome, go to network tab, then click XHR to see the 80 requests done to get the search ID and see if they answer correctly, then click WS and see if the 80 WebSockets fail or not.

I'll keep it open for a while if you want to make this check. If the problem is just too many connections I'll have to close this though. It is not the tool purposes to let you do that, but most of all, there is absolutely nothing I can do if GGG servers limit your IP address.

Azdingo commented 4 years ago

That link is locked behind your patreon, but I know a bunch of flippers who use your tool explicitly for this. A streamer recently made a tutorial on how to go from zero to hero using your tool: https://www.reddit.com/r/pathofexile/comments/ei7jb5/introducing_zero_to_hero_challenge_trading_focused/

ghostscript3r commented 4 years ago

Thanks for both information. I made the post public. And will watch/read the tutorial eagerly... I stand by what I wrote on Patreon though. The diffusion of these tools for flipping make flipping impossible for everybody. There are just not enough deals for everyone. Also, at least three users of PTE have been IP blocked by GGG, and I'd bet leet0rz is the fourth arrival to the club. That said, if poe.trade doesn't implement the same restrictions, at least there PTE can be used this way. I doubt it will ever be a feature I'll directly support though.

Azdingo commented 4 years ago

"It already happened to some users on the official site. I'm in contact with support to understand what should be the safe limit per user and will popup a warning if you try to launch more live searches then that. "

The limit is 20. https://www.pathofexile.com/forum/view-thread/2734158

leet0rz commented 4 years ago

Just closed all my browsers and opened normal tabs without the plugin, it seems to be limited to 20. I'll ask others, they might have put a limit to it after a certain streamer released all this information to the public which makes sense because it probably bombarded their trade site with too much traffic.

ghostscript3r commented 4 years ago

For what I've seen the limit is much higher then that. For example yesterday I run all your 80 searches for a while. I think once you get "flagged" (from what I've read I'd say they flag the IP, but maybe they flag the user account too), the limit drops to 20. If you are not flagged the limit is surely over 80. To get flagged you have to open a lot of connections or keep trying continuously failed connections. Once flagged you can ask to be unflagged to support (they will ask you to uninstall the tool), but I imagine they'll keep an eye on you. I read few posts of the thread you referred. I absolutely don't share the "hate" around flippers, I do believe it's an enjoyable part of the game. But I have to agree with the very first answer: "The limits are in place for a reason". If everybody using PTE (around 2k installations now) opened few hundreds web sockets it would probably end up in slow servers or higher costs for GGG. I'm not saying you are doing something bad, I'm just saying they'll never let you. After all they implemented an API that gives you all newly placed item. At the very least you should use that for flipping, like Poe Sniper application did. Really the correct implementation was it's evolution, poe-rates site. That site was consuming the big json once to serve it for every flipper, so just one call to GGG servers would serve every flpper using that. That also meant the traffic was on poe-rates server, with obviously higher maintenance costs. Too few supported that project, or even used the site without an AD Block, and so the project died. If you want a good tool for flipping the best thing to do is support poe-rates creator and hope it's enough to revive the project.

I'll close the issue since there isn't much I can do on my end. I have no problem to keep talking about it, but I think it's time to move the discussion on reddit, or https://discordapp.com/channels/630723766326001666/630723931338178561 or https://www.patreon.com/posts/poe-trade-is-not-33734746

leet0rz commented 4 years ago

I'll contact support and ask them about it. I'll probably end up using poe.trade in the meantime which is where I have most of my searches already until I tried this one and moved 80 of them over there. Yeah the poe sniper project was there for a while until it went down, didnt really try it much but I do remember it, I'll keep an eye out for similar tools. Eliminating flippers and traders would be very bad for the longevity of poe, so they better not limit our ability to live search.

On Fri, Feb 7, 2020 at 10:00 AM ghostscript3r notifications@github.com wrote:

Closed #10 https://github.com/ghostscript3r/poe-trade-official-site-enhancer/issues/10 .

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ghostscript3r/poe-trade-official-site-enhancer/issues/10?email_source=notifications&email_token=AG6S3GCTPUILVJZUQDDPIKLRBUPJ3A5CNFSM4KQM7CH2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWPI3FRY#event-3016864455, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG6S3GFWIIXRZD6JY6YBIW3RBUPJ3ANCNFSM4KQM7CHQ .

ghostscript3r commented 4 years ago

They surely don't want to limit our ability to live search, not even to snipe good deals for flipping. The API they developed is the most efficient possible server side to let all the flipper run freely. The problem is using the Trade tool for that purpose. That is really not efficient. After all that tool has a completely different purpose. Using that for flipping is too heavy server side, because the server have to manage a lot more connections, and most of all, the CPU drain of searches.