search

ghostwriternr / dashboard

Repository for MetaKGP's dashboard v2
https://beta.mykgp.com/
GNU General Public License v3.0
8 stars 5 forks source link

added redux state for fetching notices #8

Closed kektobiologist closed 6 years ago

kektobiologist commented 6 years ago

2

Awesome job man! I'm learning react and would love to contribute with other features if you could give me some kind of access to your backend. Great work!

ghostwriternr commented 6 years ago

Hey! Thanks a ton for this pull request. This also happens to be my first proper project using React and now especially Redux (everything before has just been small tutorials). So, I'm honestly learning quite a bit from this PR. I really really like how much you've cleaned up the app state code. And the addition of persisting the fetched notices even after unmount :+1:

The PR looks good to me and okay to merge right away! :star2: I just have a few very minor nitpicks that I'll add below as comments.