ghostx2 / superputty

Automatically exported from code.google.com/p/superputty
MIT License
0 stars 0 forks source link

Problem save to toolsbar #300

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Open SuperPutty
   F2 - Tab Shortcuts
2. GotoCommandBar - Ctrl+L
   GotoConnectionBar - Ctrl+H
   FullScreen - F11
3. Connect to server with ssh
   F11
   Ctrl+L
4. F11
   Exit SuperPutty
5. Open SuperPutty

What is the expected output? What do you see instead?
After open superputty the Toolbars CommandBar do not show.

What version of the product are you using? On what operating system?
1.4.0.2

Please provide any additional information below.
Attached I send my humble proposal for fix.

Original issue reported on code.google.com by foc...@gmail.com on 21 Feb 2013 at 9:39

Attachments:

GoogleCodeExporter commented 9 years ago
oh, i see.  The shortcut is allowing the user to show the toolbars in 
fullscreen mode where steps have been taken to hide them.

Original comment by btatey...@gmail.com on 22 Feb 2013 at 2:25

GoogleCodeExporter commented 9 years ago
Yes, it´s true. The problem happens in step 3, when users press Ctrl+L it 
shows the connectbar instead of commandbar.

Original comment by foc...@gmail.com on 22 Feb 2013 at 2:36

GoogleCodeExporter commented 9 years ago
to repro: 
1) have both toolbars visible
2) full screen
3) goto command bar --> goes to connection bar...wrong toolbar comes up.

Going to just disable those commands while in full screen.  I suspect few there 
are a few more bugs that might come along even after your patch...the way the 
state is tracked between the checkbox/fullscreen viewstate/settings is just not 
right.  I need to revisit it later (e.g. implement full out MVP pattern).

Original comment by btatey...@gmail.com on 17 Mar 2013 at 7:27