search

ghoti57 / evofw3

Major overhaul of evofw2 Evohome listening software to use asynchronous radio mode
61 stars 11 forks source link

Header wrong in Wiki #34

Closed tomkooij closed 1 year ago

tomkooij commented 1 year ago

I can seem to edit or send a PR for a wiki page.

The header description on: seems wrong: https://github.com/ghoti57/evofw3/wiki/Message-Body#message-body The wiki states:

00 RQ
01 W
10 I
11 RP

However in the code: https://github.com/ghoti57/evofw3/blob/59ead112b0db1880e2318475b7e36160903275fa/message.c#L164 The order is: { "RQ", "I","W","RP" } W and I seem to be swapped in the Wiki page.

Correct order according to the code:

00 RQ
01 I
10 W
11 RP

(I'm quite sure this is wrong in the Wiki, as I handcrafted a packetheader based on the wiki, and an I message was recieved as W by a real HGI80)

I'd be glad to submit a PR to the wiki, but can't figure out how.

ghoti57 commented 1 year ago

Thanks, Wiki updated.