Closed fulldecent closed 2 years ago
The function AtlasMine._vestedPrincipal retrieves the vested principal but ALSO marks it as withdrawn. This is a surprising side effect.
AtlasMine._vestedPrincipal
Surprises in functions increase complexity and create a risk of building errors into the product.
Recommendation: consider to inline _addDeposit where used as it has multiple domain-specific concerns
_addDeposit
The function
AtlasMine._vestedPrincipalretrieves the vested principal but ALSO marks it as withdrawn. This is a surprising side effect.Surprises in functions increase complexity and create a risk of building errors into the product.
Recommendation: consider to inline
_addDepositwhere used as it has multiple domain-specific concerns