search

ghoul-sol / treasure-staking

10 stars 1 forks source link

💣 Any NFT can get stuck after _setNftConfig #62

Closed fulldecent closed 2 years ago

fulldecent commented 2 years ago

In NftHandler, if a customer stakes an NFT and then the admin will use _setNftConfig to disable the NFT then the customer can no longer unstake it.

Recommendation:

  1. Track the interface detection at time of staking to allow later unstaking even if it is disabled; and/or
  2. Separate out the admin feature to disable/modify an NF config (dangerous) from the the feature to add a new NFT config (safe).
ghoul-sol commented 2 years ago

Fixed by #84