search

ghpaetzold / questplusplus

Pipelined quality estimation.
49 stars 14 forks source link

"dependencies with aligned constituents" #35

Open bittlingmayer opened 8 years ago

bittlingmayer commented 8 years ago

A few of the feature descriptions mention "dependencies with aligned constituents".

I cannot find the implementations of these features (eg 1098) in https://github.com/ghpaetzold/questplusplus/tree/master/src/shef/mt/features/impl, it would seem they should be in the dir bb/.

In any case I do not need to see the source code per se, I am happy for any guidance on what "dependencies with aligned constituents" means here concretely, and how it is calculated.

ghpaetzold commented 8 years ago

Hi Adam,

These features were removed from QuEst++ because they had compatibility issues with some other components. You can still find these features in the old QuEst repository at: https://github.com/ghpaetzold/quest/tree/master/src/shef/mt/features/impl/bb

Regards,

Gustavo Henrique Paetzold Ph.D. Candidate in Computer Science University of Sheffield

De: Adam Mathias Bittlingmayer notifications@github.com Enviado: quinta-feira, 29 de setembro de 2016 11:04:35 Para: ghpaetzold/questplusplus Assunto: [ghpaetzold/questplusplus] "dependencies with aligned constituents" (#35)

A few of the feature descriptions mention "dependencies with aligned constituents".

I cannot find the implementations of these features (eg 1098) in https://github.com/ghpaetzold/questplusplus/tree/master/src/shef/mt/features/impl, it would seem they should be in the dir bb/.

In any case I do not need to see the source code per se, I am happy for any guidance on what "dependencies with aligned constituents" means here concretely, and how it is calculated.

You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/ghpaetzold/questplusplus/issues/35, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AHrSdyQAhSeaH_iMMoHsZf8rtmd_yy-oks5qu5tDgaJpZM4KJ2_1.

bittlingmayer commented 8 years ago

Thank you

Our initial implementation simply checks if, given a source-side dep X->Y, there is a target-side dep X'->Y' where X' is among the phrase table's translations of X and Y' is among the phrase table's translations of Y. (And in one flavour of the feature we apply the threshold criterion.)

Does it sound right?

And it is it right to assume that the feature was not too impactful, if the decision was made to remove it?

ghpaetzold commented 8 years ago

Hello,

You can check the exact implementations here:

https://github.com/ghpaetzold/quest/tree/master/src/shef/mt/features/impl/bb

And yes, I do believe the feature underperformed, and that is why we could remove it.

Regards,

Gustavo Henrique Paetzold Ph.D. Candidate in Computer Science University of Sheffield

De: Adam Mathias Bittlingmayer notifications@github.com Enviado: sábado, 1 de outubro de 2016 08:11:28 Para: ghpaetzold/questplusplus Cc: Gustavo Henrique Paetzold; Comment Assunto: Re: [ghpaetzold/questplusplus] "dependencies with aligned constituents" (#35)

Thank you

Our initial implementation simply checks if, given a source-side dep X->Y, there is a target-side dep X'->Y' where X' is among the phrase table's translations of X and Y' is among the phrase table's translations of Y. (And in one flavour of the feature we apply the threshold criterion.)

Does it sound right?

And it is it right to assume that the feature was not too impactful, if the decision was made to remove it?

You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/ghpaetzold/questplusplus/issues/35#issuecomment-250899727, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AHrSdyeYYnZlj0bLJCYh6rhOfW47pWPsks5qvhWwgaJpZM4KJ2_1.