search

ghpr-asia / wsdf

Wireshark Dissector Framework
Apache License 2.0
16 stars 9 forks source link

`epan-sys-0.1.0` as a crate does not contain a git repo #17

Open Banyc opened 4 months ago

Banyc commented 4 months ago

epan-sys-0.1.0 involves building wireshark from source. Although the git repo of this project does contain a submodule called wireshark, the downloaded crate at local path ~/.cargo/registry/src/index.crates.io-6f17d22bba15001f/epan-sys-0.1.0 does not.

After running the following command in the aforementioned local path,

git submodule update --init --recursive wireshark

the output goes:

fatal: not a git repository (or any of the parent directories): .git

It seems like std::process::Command::output() did not catch this error, hidden behind the cmake error:

  CMake Error: The source directory "/Users/[REDACTED]/.cargo/registry/src/index.crates.io-6f17d22bba15001f/epan-sys-0.1.0/wireshark" does not exist.
  Specify --help for usage, or press the help button on the CMake GUI.

https://github.com/ghpr-asia/wsdf/issues/12 is the associated issue but the author closed without addressing the first case. This issue focuses on that case.

Banyc commented 4 months ago

https://github.com/ghpr-asia/wsdf/issues/16