ghtmtt / DataPlotly

D3 like plots creation with plotly in QGIS
GNU General Public License v2.0
191 stars 50 forks source link

Fix bar width #321

Closed ghtmtt closed 1 year ago

ghtmtt commented 1 year ago

New option to set the bar width to automatically. Especially useful with time series where the bar width should be manually calculated to milliseconds. With the Auto option enabled, the plotly backend will take care of it

ghtmtt commented 1 year ago

fix https://github.com/ghtmtt/DataPlotly/issues/319

ghtmtt commented 1 year ago

@Gustry do you have any idea of the failure https://github.com/ghtmtt/DataPlotly/actions/runs/4957358610/jobs/8868936585?pr=321#step:5:108? I based the template on your QuickOSM plugin ;)

Gustry commented 1 year ago

Yes, it has been raised on GitHub and mailing list : https://github.com/qgis/QGIS/pull/53053 and https://github.com/qgis/QGIS/issues/53051

The temporary solution is to disable latest from CI or allow failure.

ghtmtt commented 1 year ago

thanks @Gustry I missed the mail of the mailing list :)

Gustry commented 1 year ago

Sorry, I didn't check the PR when replying.

Any reason why raising to QGIS 3.28 minimum already ?

ghtmtt commented 1 year ago

Yes: the custom function to have same plot item colors as the map ones is not compatible with the 3.22. It might be compatible with 3.24 already but since the 3.28 is the current LTR I thought it would be better to have it compatible with version >= LTR

Gustry commented 1 year ago

the custom function to have same plot item colors as the map ones is not compatible with the 3.22.

I could have a look or we could just not add the custom function if QGIS is less than 3.24

There are still a lot of users with QGIS < 3.28.

ghtmtt commented 1 year ago

do you have the chance to test the plugin with a 3.24? So we can lower the plugin again to >= 3.24

Gustry commented 1 year ago

Let's keep like this now, a version has been released, and also #323 has been merged ;-)

We can also see it as an argument to make people speeding their migration if they really want.

ghtmtt commented 1 year ago

+1