search

ghuser-io / ghuser.io

:octocat: Better GitHub profiles
https://ghuser.io
MIT License
809 stars 47 forks source link

Followup UI improvements #159

Open lourot opened 5 years ago

lourot commented 5 years ago

After https://github.com/ghuser-io/ghuser.io/pull/158 I think we should

  1. remove 0 star badges
  2. remove/improve repetitive "explanations" like [small project] : this repo seems to be a small project

What do you think @brillout?

brillout commented 5 years ago

  1. Personally I'd rather have a maximum amount of repos shown on a profile page. Kinda like the exhaustive thing we have. Actually I thought that we could add not-self-starred repos with one condition: It's not a fork of a repo that the user has contributed to. Why do you want to get rid of smaller contribs? Some of your 0-star contribs seem to be legit. Ahhh actually I'm thinking: Do you want to keep the contrib but only remove the badge?

  2. Agree. Actually already thought about this and was thinking that a tooltip like https://popper.js.org/ could be good enough? (Instead of title=) Then no need to re-explain in the expended section. Thoughts?

lourot commented 5 years ago
  1. your last sentence yes :) I want to keep the contrib but remove the green 0 star.
  2. I'm not sure if a popper.js-tooltip is really better than a title=-tooltip, no preference, and also I'm open to move explanations fully into tooltips (this is how it used to be before #158). My point here was just about the sentence itself, which is only repeating the same words as the badge, so adding no information :)