ghuser-io / ghuser.io

:octocat: Better GitHub profiles
https://ghuser.io
MIT License
806 stars 47 forks source link

Committer/maintainer status #97

Open jayvdb opened 6 years ago

jayvdb commented 6 years ago

Tightly related to https://github.com/AurelienLourot/ghuser.io/issues/36 , committer/maintainer should be separate from the percentage of contributions.

Older developers on large established codebases often will fall short of any contribution threshold, as they spend more time doing code reviews and merging. In a repo which uses fast-forward merges, their effort will be hidden from typical analysis.

c.f. https://github.com/kentcdodds/all-contributors/issues/81

lourot commented 6 years ago

Makes sense, thanks @jayvdb!

For reference our related chats that contain useful details:

jayvdb commented 6 years ago

The easiest way to determine write permission is via GitHub commit metadata , and to reduce work required it would be 'good enough' to only inspect committee for the pull requests the user created , as that data is already fetched.