search

ghusse / jQRangeSlider

A jquery UI range selection slider that supports dates
http://ghusse.github.com/jQRangeSlider/
GNU General Public License v3.0
671 stars 147 forks source link

DateRangeSlider: inverted label order with small range #144

Closed grpiedade closed 10 years ago

grpiedade commented 11 years ago

The labels are inverted when the min / max values (changed programmatically) are too close.

Reproduce: http://jsfiddle.net/grpiedade/L48jY/ Click Run and watch as the seconds increase. The labels order will be inverted for some time, then there will be just one label and finally the labels will be correct as expected. The range needed to get the labels in the correct order varies depending on the slider size.

grpiedade commented 10 years ago

Is this really a bug or am I doing something wrong?

ghusse commented 10 years ago

It is probably a bug introduced in latest version. It changed how handles are placed. Le 27 nov. 2013 13:12, "grpiedade" notifications@github.com a écrit :

Is this really a bug or am I doing something wrong?

— Reply to this email directly or view it on GitHubhttps://github.com/ghusse/jQRangeSlider/issues/144#issuecomment-29379836 .

jamienk commented 10 years ago

This is a blocker for me. Can you point me to the area where this method is? I can't easily find it in the code. I will do a pull request if I'm able to fix it... Thanks in advance.

ghusse commented 10 years ago

Nice !

This object is responsible for positionning labels: https://github.com/ghusse/jQRangeSlider/blob/master/jQRangeSliderLabel.js#L215

ghusse commented 10 years ago

Fixed in 5.6.0

ghost commented 10 years ago

I'm using 5.6.0 with jqueryui 1.10.3 and jquery 1.10.2 and it seems the problem is still persistent. The #146 too

ghost commented 10 years ago

Anyone got this again?

noelsison commented 10 years ago

Yes, still inverted on close min and max values when using jQDateRangeSlider. Happens when setting the minimum date.

grpiedade commented 10 years ago

Long time I don't visit this. I tested 5.7.0 now and the issue is fixed. Thanks!