search

ghutchis / avogadro

Avogadro is an advanced molecular editor designed for cross-platform use in computational chemistry, molecular modeling, bioinformatics, materials science, and related areas. It offers flexible rendering and a powerful plugin architecture.
http://avogadro.cc/
GNU General Public License v2.0
2 stars 0 forks source link

gamessinputdata.h line 518 #697

Closed ghutchis closed 8 years ago

ghutchis commented 10 years ago

libavogadro\src\extensions\quantuminput\gamessinputdata.h line 518 :

inline short SetGuess(short NewGuess) {if ((NewGuess<0)&&(NewGuess>5)) return -1; GuessType = NewGuess; return GetGuess();};

Logical conjunction always evaluates to false: NewGuess < 0 && NewGuess > 5.

May be it bug.

Snapshot avogadro-code-bbf9a0dcc3448ca7d604ede03108a7dfc8fcef32.

I use cppcheck. Thanks.

Reported by: ttttrrrr