search

gi-ev / LNI

A LaTeX class for submissions to the “Lecture Notes in Informatics” (LNI) published by the German “Gesellschaft für Informatik” (GI)
https://www.ctan.org/pkg/lni
LaTeX Project Public License v1.3c
40 stars 33 forks source link

Fix hyperlinks to references #116

Closed koppor closed 1 year ago

koppor commented 1 year ago

Fixes https://github.com/gi-ev/LNI/issues/107

(and minor adaptions to build.sh and wording at lni.dtx)

sieversMartin commented 1 year ago

I am not sure, whether loading in the middle of the preamble is a good idea. We should look for another solution IMHO.

sieversMartin commented 1 year ago

We should keep the load order, but work with hyperref=manual and \BiblatexManualHyperrefOn. See https://github.com/gi-ev/LNI/tree/fix-107-ms

koppor commented 1 year ago

The fix looks nice! Thank you.

In general, we should think about supporting addition of packages, which need to be loaded after hyperref. A huge discussion is at https://tex.stackexchange.com/q/1863/9075. - I am very glad that no user reported issues in loading additional packages. I am unsure whether this is luck or because the class is properly engineered ^^.

Maybe using pkgloader could help? However, this is a solution not widely in use and may cause other issues.

koppor commented 1 year ago

I close this PR and will merge the other commit to move forward.