search

giabaio / BCEA

Bayesian Cost Effectiveness Analysis. Given the results of a Bayesian model (possibly based on MCMC) in the form of simulations from the posterior distributions of suitable variables of costs and clinical benefits for two or more interventions, produces a health economic evaluation. Compares one of the interventions (the "reference") to the others ("comparators"). Produces many summary and plots to analyse the results
https://gianluca.statistica.it/software/bcea/
GNU General Public License v3.0
40 stars 16 forks source link

test pull request #20

Closed n8thangreen closed 4 years ago

n8thangreen commented 4 years ago

Hi,

I've just made some nominal changes to try this out. I think it may be worth creating a dev branch from master and then I can do the pull requests in to dev. What do you think? I also thought it would be nice to add some tests so I've set up the testthat folder.

Thanks,N

giabaio commented 4 years ago

That was quick... ;-) Thanks! All approved and dev branch created --- good idea. Was always at the back of my mind, but never got around to doing it...

giabaio commented 4 years ago

Thank you, @andbe. Also notice we've started a dev fork --- let's work incrementally on that! Thanks G

On Tue, 19 May 2020 at 14:20, andbe notifications@github.com wrote:

@andbe commented on this pull request.

In R/bcea.default.R https://github.com/giabaio/BCEA/pull/20#discussion_r427295481:

Set the working directory to wherever the user is working, if not externally set

  • if(!exists("working.dir")){working.dir <- getwd()}
  • if(!exists("working.dir")){working.dir <- here::here()}

I'd suggest removing this line as there are no other references in the code to working.dir (no other references to the object throughout the code), or adding "here" to imported packages as the line would fail otherwise

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/giabaio/BCEA/pull/20#pullrequestreview-414436355, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCRVSL3DHNS3YU7XTGDOZTRSKBR5ANCNFSM4NAZWCBA .

--

Gianluca Baio

Professor of Statistics & Health Economics Department of Statistical Science University College London 1-19 Torrington Place, London WC1E 6BT, UK Telephone +44(0)20 7679 1248 (internal: 41248) Fax +44 (0)20 7383 4703 Website: http://www.homepages.ucl.ac.uk/~ucakgba http://www.homepages.ucl.ac.uk/~ucakgba/ Blog: http:www.statistica.it/gianluca/blog

https://twitter.com/gianlubaio https://www.linkedin.com/in/gianluca-baio-b893879/ https://www.facebook.com/gianluca.baio.1 https://github.com/giabaio https://scholar.google.co.uk/citations?user=ro0QvGsAAAAJ&hl=en https://www.researchgate.net/profile/Gianluca_Baio https://orcid.org/0000-0003-4314-2570

DUE TO THE COVID-19 EMERGENCY, WE'VE DECIDED TO KEEP THE CHILDREN HOME FROM SCHOOL (BEFORE THE GOVERNMENT CLOSED THEM ANYWAY). THUS, I WILL PROBABLY HAVE ERRATIC WORKING HOURS IN THE NEXT FEW DAYS/WEEKS. I MAY BE SLOWER IN REPLYING TO EMAILS OR SEND THEM AT UNGODLY HOURS. PLEASE BEAR WITH ME.