search

giabaio / BCEA

Bayesian Cost Effectiveness Analysis. Given the results of a Bayesian model (possibly based on MCMC) in the form of simulations from the posterior distributions of suitable variables of costs and clinical benefits for two or more interventions, produces a health economic evaluation. Compares one of the interventions (the "reference") to the others ("comparators"). Produces many summary and plots to analyse the results
https://gianluca.statistica.it/software/bcea/
GNU General Public License v3.0
40 stars 16 forks source link

ceaf plot change #22

Closed n8thangreen closed 4 years ago

n8thangreen commented 4 years ago

I think the reason the comment about a jagged line in this plot is because it wasnt using the correct ceaf values. In fact the correct line is commented out in multi.ce() for some reason. I simply uncommented it to replace the previous code and tidied up ceaf.plot() a bit

giabaio commented 4 years ago

Thanks! I've merged the pull request - note I've made a couple of changes myself: 1) I've fixed a problem in plot-bcea.Rd (there was an extra space and it wouldn't let me install the package otherwise); 2) I've added your name & details in the DESCRIPTION file among the authors 3) I've updated the version to 2.4 in preparation to a full release.

When you install, there are a couple of warnings:

> devtools::install_github("giabaio/BCEA",ref="dev")
Downloading GitHub repo giabaio/BCEA@dev
✓  checking for file ‘/tmp/RtmpZtD2Bz/remotes4ec21caebd0/giabaio-BCEA-73bc475/DESCRIPTION’ ...
─  preparing ‘BCEA’:
✓  checking DESCRIPTION meta-information ...
─  checking for LF line-endings in source and make files and shell scripts
─  checking for empty or unneeded directories
─  looking to see if a ‘data/datalist’ file should be added
     NB: this package now depends on R (>= 3.5.0)
     WARNING: Added dependency on R >= 3.5.0 because serialized objects in  serialize/load version 3 cannot be read in older versions of R.  File(s) containing such objects: 'BCEA/tests/testthat/ce.RData'
─  building 'BCEA_2.4.tar.gz'

Installing package into ‘/home/gianluca/R/x86_64-pc-linux-gnu-library/libs’
(as ‘lib’ is unspecified)
* installing *source* package ‘BCEA’ ...
** using staged installation
** R
** data
** inst
** byte-compile and prepare package for lazy loading
Note: ... may be used in an incorrect context 
Note: ... may be used in an incorrect context 
Note: ... may be used in an incorrect context 
Note: ... may be used in an incorrect context 
** help
*** installing help indices
** building package indices
** installing vignettes
** testing if installed package can be loaded from temporary location
** testing if installed package can be loaded from final location
** testing if installed package keeps a record of temporary installation path
* DONE (BCEA)
>

I think the first one is because the current version of the DESCRIPTION file refers to an older version of R --- easy to fix, I think, and will do later. The other one is a bit more obscure --- I need to check carefully but it has to do with ... being used in incorrect context (but not clear in what function, I think). Will dig out more --- but it does install fine, otherwise.

n8thangreen commented 4 years ago

Great. the ... thing is probably because Ive used it in a higher/lower lever function and not in a lower/higher so it doesnt go anywhere. I'll have a look

giabaio commented 4 years ago

Thanks!

On Wed, 22 Jul 2020 at 10:06, Dr Nathan Green notifications@github.com wrote:

Great. the ... thing is probably because Ive used it in a higher/lower lever function and not in a lower/higher so it doesnt go anywhere. I'll have a look

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/giabaio/BCEA/pull/22#issuecomment-662337507, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCRVSJPMZEFW4INTEUEPDLR42T2JANCNFSM4PD2D3KA .

--

Gianluca Baio

Professor of Statistics & Health Economics Department of Statistical Science University College London 1-19 Torrington Place, London WC1E 6BT, UK Telephone +44(0)20 7679 1248 (internal: 41248) Fax +44 (0)20 7383 4703 Website: http://www.homepages.ucl.ac.uk/~ucakgba http://www.homepages.ucl.ac.uk/~ucakgba/ Blog: http:www.statistica.it/gianluca/blog

https://twitter.com/gianlubaio https://www.linkedin.com/in/gianluca-baio-b893879/ https://github.com/giabaio https://scholar.google.co.uk/citations?user=ro0QvGsAAAAJ&hl=en https://www.researchgate.net/profile/Gianluca_Baio https://orcid.org/0000-0003-4314-2570

DUE TO THE COVID-19 EMERGENCY, I WILL PROBABLY HAVE ERRATIC WORKING HOURS IN THE NEXT FEW DAYS/WEEKS/MONTHS/YEARS. I MAY BE SLOWER IN REPLYING TO EMAILS OR SEND THEM AT UNGODLY HOURS. PLEASE BEAR WITH ME.