Closed giabaio closed 1 year ago
Hi @giabaio I'm not quite sure what to do. Could you send me a reprex, please? what is the example you're looking at? whats the error and what should it be? Thanks!
closed with 6a006e3aacb587598e0ba99e3270eaab931307ca
@giabaio could you close this please (I don't seem to have rights)
Done! Thanks
Gianluca Baio Professor of Statistics and Health Economics | Head of Department
Department of Statistical Science | University College London 1-19 Torrington Place, London, WC1E 6BT, UK Twitter: @stats_uclhttps://twitter.com/stats_UCL | Instagram: @stats_UCLhttps://instagram.com/ucl.stats/
Telephone: +44(0)20 7679 1248 (internal: 41248) Website: http://www.homepages.ucl.ac.uk/~ucakgba Blog: https://gianluca.statistica.it/blog/ Book a meeting with me: https://book.morgen.so/gianlucabaio/book-me
@.***> [https://www.svgrepo.com/show/157815/twitter.svg] https://twitter.com/gianlubaio [https://www.svgrepo.com/show/138936/linkedin.svg] https://www.linkedin.com/in/gianluca-baio-b893879/ [https://www.svgrepo.com/show/341847/github.svg] https://github.com/giabaio [https://www.geol.umd.edu/styles/academicons-192/svg/arxiv.svg] https://arxiv.org/a/baio_g_1.html [https://www.geol.umd.edu/styles/academicons-192/svg/orcid.svg] https://orcid.org/0000-0003-4314-2570 [https://www.svgrepo.com/show/40973/soundcloud.svg] https://soundcloud.com/uclsound/sets/sample-space
For Head of Department correspondence, please use @.**@.>
[https://s1g.s3.amazonaws.com/3f32ef1962be41fb8943ee58d28cf3aa.png]
This email may reach you outside of your working hours. If that’s the case, please do not feel pressure to reply immediately.
From: Dr Nathan Green @.> Sent: 27 January 2023 18:30 To: giabaio/BCEA @.> Cc: Baio, Gianluca @.>; Mention @.> Subject: Re: [giabaio/BCEA] Inconsistency in summary table (Issue #44)
⚠ Caution: External sender
@giabaiohttps://github.com/giabaio could you close this please (I don't seem to have rights)
— Reply to this email directly, view it on GitHubhttps://github.com/giabaio/BCEA/issues/44#issuecomment-1406922812, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACCRVSKZYKBPDU3QFJN5UMTWUQH5DANCNFSM6AAAAAAUAQJ6BQ. You are receiving this because you were mentioned.Message ID: @.***>
@n8thangreen I think there's a slight inconsistency in the way you've refactored the
summary
method. You have codedrownames(EU_tab) <- he$interventions[c(he$ref, he$comp)]
which implies that the first row of the table must be the reference intervention. But this doesn't propagate to the full table, so in the examples I was checking, you actually have data in the order provided by theeff
,cost
matrices (so: first column=intervention1, second column=intervention2 and so, with no reference to the choice of the reference intervention), but then the row names are not matching that.The drawback is that you'd get blatant inconsistencies, such as with the most cost-effective intervention not being associated with the highest expected utility (simply because of reordering of the row labels...).
I've fixed it temporarily by simply changing the code above to
rownames(EU_tab) <- he$interventions
--- but I'm not sure this breaks something else down the line...Can you please when you have a moment have a look?
Thanks!