search

giabaio / BCEA

Bayesian Cost Effectiveness Analysis. Given the results of a Bayesian model (possibly based on MCMC) in the form of simulations from the posterior distributions of suitable variables of costs and clinical benefits for two or more interventions, produces a health economic evaluation. Compares one of the interventions (the "reference") to the others ("comparators"). Produces many summary and plots to analyse the results
https://gianluca.statistica.it/software/bcea/
GNU General Public License v3.0
40 stars 16 forks source link

sync dev branches up to release v2.4.1 #45

Closed n8thangreen closed 1 year ago

n8thangreen commented 1 year ago

I just noticed that the dev branch in your repo is over 100 commits behind mine but the main is up to date which is weird! I suppose it would have made more sense to originally synced with your dev and then let you sync with your main rather than to your main directly.

giabaio commented 1 year ago

Thank you, @n8thangreen. Just to make sure, in summary.bcea.R, the line

rownames(EU_tab) <- he$interventions[as.numeric(interv_idx)]

is supposed to fix the issue we discussed the other day (which I had simply fixed by setting the rownames to he$interventions?

Thanks!

n8thangreen commented 1 year ago

The slight change I made was to account for when the interventions are not in numeric order.

Also TODO, the original fix for summary.bcea doesn't work properly when there are a subset of all of the interventions. It still prints the kstar for all of them. I had a look over the weekend and its because kstar and best aren't changed in the bcea call. The thing to do is change new_bcea but making sure this then doesnt break something else!

giabaio commented 1 year ago

Thanks. I'll merge this now!